Skip to content

fix(run): clarify skill scan log — blocked vs uploading #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ralphbean wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

fix(run): clarify skill scan log — blocked vs uploading #1172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions internal/cli/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,9 +763,9 @@ func bootstrapSandbox(sandboxName, repoDir, fullsendBinary string, h *harness.Ha
if h.FailModeClosed() {
return fmt.Errorf("skill %q blocked: critical injection findings in SKILL.md", skillPath)
}
fmt.Fprintf(os.Stderr, "WARNING: skill %q has critical injection findings (fail_mode: open)\n", skillPath)
fmt.Fprintf(os.Stderr, "WARNING: skill %q has critical injection findings (fail_mode: open) — uploading anyway\n", skillPath)
} else if len(result.Findings) > 0 {
fmt.Fprintf(os.Stderr, "WARNING: skill %q has %d injection finding(s)\n", skillPath, len(result.Findings))
fmt.Fprintf(os.Stderr, "WARNING: skill %q has %d non-critical injection finding(s) — not blocked (only critical findings block); uploading\n", skillPath, len(result.Findings))
}
}
}
Expand All @@ -774,6 +774,7 @@ func bootstrapSandbox(sandboxName, repoDir, fullsendBinary string, h *harness.Ha
fmt.Sprintf("%s/skills/", sandbox.SandboxClaudeConfig)); err != nil {
return fmt.Errorf("copying skill %q: %w", skillPath, err)
}
fmt.Fprintf(os.Stderr, "Skill %q: uploaded to sandbox\n", filepath.Base(skillPath))
}

// Scan plugin definitions for injection before copying into sandbox.
Expand Down
Loading