fix(run): clarify skill scan log — blocked vs uploading#1172
Open
ralphbean wants to merge 1 commit into
Open
Conversation
The log line "WARNING: skill X has N injection finding(s)" gave no indication of whether the skill was blocked or uploaded. A high-severity finding looks alarming but does not block the upload; only critical findings do (when fail_mode is closed). This made post-hoc debugging ambiguous. Changes: - Non-critical findings: append "— not blocked (only critical findings block); uploading" so the disposition is unambiguous - Critical findings with fail_mode open: append "— uploading anyway" - After every successful upload: log "Skill X: uploaded to sandbox" so the upload completion is visible in job logs independently of the scan Assisted-by: Claude claude-sonnet-4-6 <[email protected]> Signed-off-by: Ralph Bean <[email protected]>
Site previewPreview: https://49c79a5a-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsNo findings. |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WARNING: skill X has N injection finding(s)gave no indication of what happened next — the skill could be blocked or uploaded and the log looked the samefail_mode: closed); high/medium/low findings just warnBefore / after
Non-critical finding (was):
Non-critical finding (now):
Critical finding, fail_mode open (now):
Critical finding, fail_mode closed (unchanged — returns error, run aborts):
Test plan
go vetandmake lintpass