[FIX] Gersoon resources pack #503
Conversation
This reverts commit 85b86f2.
|
Warning Rate limit exceeded@github-actions[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 56 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (270)
📒 Files selected for processing (28)
WalkthroughThe recent updates introduce significant enhancements across various YAML and JSON files, refining item definitions, improving visual decals, and reorganizing structural elements. Key changes include clarifying identifiers, streamlining asset paths, and adding new entities, all aimed at enhancing functionality and aesthetic appeal for a more engaging user experience. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant System
participant PlantSpawner
User->>System: Request potted plants
System->>PlantSpawner: Generate random plants
PlantSpawner-->>System: Return plant instances
System-->>User: Display random potted plants
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| - id: ClothingHandsGlovesCombat | ||
| - id: ClothingShoesBootsJack | ||
| - id: ClothingEyesGlassesSecurity | ||
| - id: ClothingHeadsetAltSecurityCommand |
There was a problem hiding this comment.
Вернуть, в Командной стоит ключ командования, в обычной нет. А это комод хоса
| description: Do not apply fire to this. Rumour says it burns easily. | ||
| components: | ||
| - type: Sprite | ||
| sprite: White/Structures/Furniture/Tables/wood.rsi |
There was a problem hiding this comment.
Все спрайты наши должны быть в вайтпапке, иначе они легко могут проебаться. Спрайты переложить в вайтпапку, пути вернуть
add: Tile resprite + new tiles add: Sign resprite + new signs add: Decal resprite + new decals add: Furniture resprites add: Dohuya drugogo resprites
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (3)
Resources/Prototypes/Tiles/plating.yml (2)
16-17: Discrepancy in the number of placement variants for PlatingDamaged tileThe sprite path is valid, and the number of variants is set to 4. However, the
placementVariantssection inResources/Prototypes/Tiles/plating.ymllists only three entries. Ensure that all four variants are correctly implemented.
- File:
Resources/Prototypes/Tiles/plating.yml- Lines: 16-20
Analysis chain
Update sprite path and variants for PlatingDamaged tile.
The sprite path has been updated, and the number of variants increased to 4. Ensure that all variants are correctly implemented and that the new sprite path is valid.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the existence of the updated sprite path and check for variants. fd 'plating_damaged.png' Resources/Textures/White/Tiles --exec echo "Found: {}"Length of output: 137
Script:
#!/bin/bash # Search for references to the 'plating_damaged' sprite to verify variant implementation. rg 'plating_damaged' -A 5Length of output: 1178
34-35: Potential mismatch between variants and placementVariants for PlatingBurnt tile.The
PlatingBurnttile is defined with 4 variants, but theplacementVariantsfield contains only a single value. Ensure that the number ofplacementVariantsmatches the number of variants if each variant requires a unique placement configuration.
- File:
Resources/Prototypes/Tiles/plating.yml
- Line:
variants: 4- Line:
placementVariants: [1.0]Analysis chain
Update sprite path and variants for PlatingBurnt tile.
The sprite path has been updated, and variants have been added. Ensure the sprite path is valid and that all variants are correctly defined.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the existence of the updated sprite path for PlatingBurnt tile. fd 'plating_burnt.png' Resources/Textures/White/Tiles --exec echo "Found: {}"Length of output: 133
Script:
#!/bin/bash # Search for the definition and usage of the PlatingBurnt tile variants in the codebase. rg 'PlatingBurnt' -A 5Length of output: 4812
Resources/Prototypes/Tiles/floors.yml (1)
2037-2037: Update the sprite path forFloorAsteroidSandDug.The sprite file
asteroid_dug.pngexists inResources/Textures/Tiles/Asteroid/asteroid_dug.png. Please update the reference in the code to reflect this correct path.
- Incorrect path:
/Textures/White/Tiles/Asteroid/asteroid_dug.png- Correct path:
Resources/Textures/Tiles/Asteroid/asteroid_dug.pngAnalysis chain
Verify the new sprite path for
FloorAsteroidSandDug.The sprite path has been updated to
/Textures/White/Tiles/Asteroid/asteroid_dug.png. Ensure this path is correct and that the asset exists in the specified directory.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of the new sprite path for `FloorAsteroidSandDug`. # Test: Check if the file exists at the new path. fd 'asteroid_dug.png' -t f --search-path /Textures/White/Tiles/Asteroid/Length of output: 191
Script:
#!/bin/bash # Description: Search for the 'asteroid_dug.png' file in the entire repository to verify its existence. # Search for the file 'asteroid_dug.png' in the repository. fd 'asteroid_dug.png' -t fLength of output: 77
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (270)
Resources/Textures/Decals/Overlays/greyscale.rsi/checkerNESW.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/checkerNWSE.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/diagonal.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/diagonal_checker_a.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/diagonal_checker_b.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/fulltile_overlay.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/halftile_overlay.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/halftile_overlay_180.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/halftile_overlay_270.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/halftile_overlay_90.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/herringbone.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/minitile.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/minitile_checker_a.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/minitile_checker_b.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/minitile_diagonal.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/minitile_diagonal_a.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/minitile_diagonal_b.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/mono.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/offset.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/offset_checker_a.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/offset_checker_b.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/pavement.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/pavement_checker_a.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/pavement_checker_b.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/pavement_vertical.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/pavement_vertical_checker_a.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/pavement_vertical_checker_b.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/quartertile_overlay.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/quartertile_overlay_180.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/quartertile_overlay_270.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/quartertile_overlay_90.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/threequartertile_overlay.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/threequartertile_overlay_180.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/threequartertile_overlay_270.pngis excluded by!**/*.pngResources/Textures/Decals/Overlays/greyscale.rsi/threequartertile_overlay_90.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/dark_box.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/dark_corner_ne.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/dark_corner_nw.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/dark_corner_se.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/dark_corner_sw.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/dark_end_e.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/dark_end_n.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/dark_end_s.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/dark_end_w.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/dark_inner_ne.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/dark_inner_nw.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/dark_inner_se.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/dark_inner_sw.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/dark_line_e.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/dark_line_n.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/dark_line_s.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/dark_line_w.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/steel_box.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/steel_corner_ne.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/steel_corner_nw.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/steel_corner_se.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/steel_corner_sw.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/steel_end_e.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/steel_end_n.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/steel_end_s.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/steel_end_w.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/steel_inner_ne.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/steel_inner_nw.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/steel_inner_se.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/steel_inner_sw.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/steel_line_e.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/steel_line_n.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/steel_line_s.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/steel_line_w.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/white_box.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/white_corner_ne.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/white_corner_nw.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/white_corner_se.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/white_corner_sw.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/white_end_e.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/white_end_n.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/white_end_s.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/white_end_w.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/white_inner_ne.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/white_inner_nw.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/white_inner_se.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/white_inner_sw.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/white_line_e.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/white_line_n.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/white_line_s.pngis excluded by!**/*.pngResources/Textures/Decals/bricktile.rsi/white_line_w.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/arrows.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/arrows_greyscale.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/bot.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/bot_greyscale.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/bot_left.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/bot_left_greyscale.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/bot_right.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/bot_right_greyscale.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/box.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/box_greyscale.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/caution.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/caution_greyscale.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/delivery.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/delivery_greyscale.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/loading_area.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/loading_area_greyscale.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/standclear.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/standclear_greyscale.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_box.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_box_greyscale.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_corner.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_corner_flipped.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_corner_flipped_greyscale.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_corner_greyscale.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_corner_greyscale_ne.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_corner_greyscale_nw.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_corner_greyscale_se.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_corner_greyscale_sw.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_corner_ne.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_corner_nw.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_corner_se.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_corner_small_greyscale_ne.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_corner_small_greyscale_nw.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_corner_small_greyscale_se.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_corner_small_greyscale_sw.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_corner_small_ne.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_corner_small_nw.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_corner_small_se.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_corner_small_sw.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_corner_sw.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_end.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_end_e.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_end_greyscale.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_end_greyscale_e.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_end_greyscale_n.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_end_greyscale_s.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_end_greyscale_w.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_end_n.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_end_s.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_end_w.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_full.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_full_greyscale.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_line_e.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_line_greyscale_e.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_line_greyscale_n.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_line_greyscale_s.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_line_greyscale_w.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_line_n.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_line_s.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warn_line_w.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warningline.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warningline_greyscale.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warninglinecorner.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warninglinecorner_flipped.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warninglinecorner_flipped_greyscale.pngis excluded by!**/*.pngResources/Textures/Decals/markings.rsi/warninglinecorner_greyscale.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/dark_box.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/dark_corner_ne.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/dark_corner_nw.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/dark_corner_se.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/dark_corner_sw.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/dark_end_e.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/dark_end_n.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/dark_end_s.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/dark_end_w.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/dark_inner_ne.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/dark_inner_nw.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/dark_inner_se.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/dark_inner_sw.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/dark_line_e.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/dark_line_n.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/dark_line_s.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/dark_line_w.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/steel_box.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/steel_corner_ne.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/steel_corner_nw.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/steel_corner_se.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/steel_corner_sw.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/steel_end_e.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/steel_end_n.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/steel_end_s.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/steel_end_w.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/steel_inner_ne.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/steel_inner_nw.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/steel_inner_se.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/steel_inner_sw.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/steel_line_e.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/steel_line_n.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/steel_line_s.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/steel_line_w.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/white_box.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/white_corner_ne.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/white_corner_nw.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/white_corner_se.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/white_corner_sw.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/white_end_e.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/white_end_n.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/white_end_s.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/white_end_w.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/white_inner_ne.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/white_inner_nw.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/white_inner_se.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/white_inner_sw.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/white_line_e.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/white_line_n.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/white_line_s.pngis excluded by!**/*.pngResources/Textures/Decals/minitile.rsi/white_line_w.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/dark_box.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/dark_corner_ne.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/dark_corner_nw.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/dark_corner_se.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/dark_corner_sw.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/dark_end_e.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/dark_end_n.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/dark_end_s.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/dark_end_w.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/dark_inner_ne.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/dark_inner_nw.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/dark_inner_se.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/dark_inner_sw.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/dark_line_e.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/dark_line_n.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/dark_line_s.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/dark_line_w.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/steel_box.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/steel_corner_ne.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/steel_corner_nw.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/steel_corner_se.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/steel_corner_sw.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/steel_end_e.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/steel_end_n.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/steel_end_s.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/steel_end_w.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/steel_inner_ne.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/steel_inner_nw.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/steel_inner_se.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/steel_inner_sw.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/steel_line_e.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/steel_line_n.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/steel_line_s.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/steel_line_w.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/white_box.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/white_corner_ne.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/white_corner_nw.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/white_corner_se.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/white_corner_sw.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/white_end_e.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/white_end_n.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/white_end_s.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/white_end_w.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/white_inner_ne.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/white_inner_nw.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/white_inner_se.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/white_inner_sw.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/white_line_e.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/white_line_n.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/white_line_s.pngis excluded by!**/*.pngResources/Textures/Decals/trim.rsi/white_line_w.pngis excluded by!**/*.pngResources/Textures/Decals/trim_markings.rsi/warn_box.pngis excluded by!**/*.pngResources/Textures/Decals/trim_markings.rsi/warn_box_greyscale.pngis excluded by!**/*.pngResources/Textures/Decals/trim_markings.rsi/warn_corner_greyscale_ne.pngis excluded by!**/*.pngResources/Textures/Decals/trim_markings.rsi/warn_corner_greyscale_nw.pngis excluded by!**/*.pngResources/Textures/Decals/trim_markings.rsi/warn_corner_greyscale_se.pngis excluded by!**/*.pngResources/Textures/Decals/trim_markings.rsi/warn_corner_greyscale_sw.pngis excluded by!**/*.pngResources/Textures/Decals/trim_markings.rsi/warn_corner_ne.pngis excluded by!**/*.pngResources/Textures/Decals/trim_markings.rsi/warn_corner_nw.pngis excluded by!**/*.pngResources/Textures/Decals/trim_markings.rsi/warn_corner_se.pngis excluded by!**/*.pngResources/Textures/Decals/trim_markings.rsi/warn_corner_small_greyscale_ne.pngis excluded by!**/*.pngResources/Textures/Decals/trim_markings.rsi/warn_corner_small_greyscale_nw.pngis excluded by!**/*.pngResources/Textures/Decals/trim_markings.rsi/warn_corner_small_greyscale_se.pngis excluded by!**/*.pngResources/Textures/Decals/trim_markings.rsi/warn_corner_small_greyscale_sw.pngis excluded by!**/*.pngResources/Textures/Decals/trim_markings.rsi/warn_corner_small_ne.pngis excluded by!**/*.pngResources/Textures/Decals/trim_markings.rsi/warn_corner_small_nw.pngis excluded by!**/*.pngResources/Textures/Decals/trim_markings.rsi/warn_corner_small_se.pngis excluded by!**/*.png
Files selected for processing (28)
- Resources/Locale/ru-RU/ss14-ru/prototypes/entities/structures/wallmounts/signs/signs.ftl (12 hunks)
- Resources/Prototypes/Catalog/Fills/Lockers/dressers.yml (1 hunks)
- Resources/Prototypes/Entities/Objects/Misc/tiles.yml (4 hunks)
- Resources/Prototypes/Entities/Structures/Doors/MaterialDoors/material_doors.yml (1 hunks)
- Resources/Prototypes/Entities/Structures/Furniture/Tables/tables.yml (2 hunks)
- Resources/Prototypes/Entities/Structures/Furniture/chairs.yml (3 hunks)
- Resources/Prototypes/Entities/Structures/Machines/fax_machine.yml (2 hunks)
- Resources/Prototypes/Entities/Structures/Piping/Disposal/units.yml (2 hunks)
- Resources/Prototypes/Entities/Structures/Power/apc.yml (2 hunks)
- Resources/Prototypes/Entities/Structures/Storage/Closets/base_structureclosets.yml (3 hunks)
- Resources/Prototypes/Entities/Structures/Wallmounts/Signs/signs.yml (47 hunks)
- Resources/Prototypes/Entities/Structures/Wallmounts/defib_cabinet.yml (2 hunks)
- Resources/Prototypes/Entities/Structures/Wallmounts/extinguisher_cabinet.yml (2 hunks)
- Resources/Prototypes/Entities/Structures/Wallmounts/monitors_televisions.yml (1 hunks)
- Resources/Prototypes/Entities/Structures/Wallmounts/shelfs.yml (10 hunks)
- Resources/Prototypes/Entities/Structures/Wallmounts/switch.yml (6 hunks)
- Resources/Prototypes/Entities/Structures/barricades.yml (3 hunks)
- Resources/Prototypes/Palettes/advanced.yml (2 hunks)
- Resources/Prototypes/Recipes/Crafting/Graphs/tiles.yml (1 hunks)
- Resources/Prototypes/Recipes/Crafting/tiles.yml (1 hunks)
- Resources/Prototypes/Tiles/floors.yml (68 hunks)
- Resources/Prototypes/Tiles/plating.yml (4 hunks)
- Resources/Prototypes/_White/Decals/trim.yml (1 hunks)
- Resources/Prototypes/_White/Decals/trim_markings.yml (1 hunks)
- Resources/Prototypes/_White/Decals/window_frame.yml (1 hunks)
- Resources/Prototypes/_White/Entities/Structures/Furniture/random_potted_plants.yml (1 hunks)
- Resources/Textures/Decals/trim.rsi/meta.json (1 hunks)
- Resources/Textures/Decals/trim_markings.rsi/meta.json (1 hunks)
Files skipped from review due to trivial changes (12)
- Resources/Prototypes/Catalog/Fills/Lockers/dressers.yml
- Resources/Prototypes/Entities/Structures/Doors/MaterialDoors/material_doors.yml
- Resources/Prototypes/Entities/Structures/Furniture/Tables/tables.yml
- Resources/Prototypes/Entities/Structures/Piping/Disposal/units.yml
- Resources/Prototypes/Entities/Structures/Power/apc.yml
- Resources/Prototypes/Entities/Structures/Wallmounts/defib_cabinet.yml
- Resources/Prototypes/Entities/Structures/Wallmounts/extinguisher_cabinet.yml
- Resources/Prototypes/Entities/Structures/Wallmounts/shelfs.yml
- Resources/Prototypes/Entities/Structures/barricades.yml
- Resources/Prototypes/Palettes/advanced.yml
- Resources/Prototypes/Recipes/Crafting/Graphs/tiles.yml
- Resources/Prototypes/Recipes/Crafting/tiles.yml
Additional context used
yamllint
Resources/Prototypes/_White/Decals/window_frame.yml
[error] 118-118: no new line character at the end of file
(new-line-at-end-of-file)
Additional comments not posted (47)
Resources/Textures/Decals/trim_markings.rsi/meta.json (1)
1-113: File Approved: Metadata for texture decals is well-structured.The JSON file is correctly formatted and contains all necessary metadata for the texture decals. The states are clearly defined, which should facilitate their use in the application.
Resources/Prototypes/Entities/Structures/Machines/fax_machine.yml (1)
24-24: Verify the impact of bounding box dimension changes.The bounding box dimensions for
FaxMachineBasehave been increased. Ensure that this change does not negatively affect interactions or collision detection with other entities.Resources/Textures/Decals/trim.rsi/meta.json (1)
1-164: JSON Structure and Metadata Check.The JSON structure is correct, and metadata such as version, license, and copyright are appropriately defined. The states are well-organized, each with a unique name. Ensure that the referenced textures exist and are correctly linked in the application.
Resources/Prototypes/Tiles/plating.yml (5)
4-4: Update sprite path for Plating tile.The sprite path for the
Platingtile has been updated to a new directory. Ensure that the new path is correct and that the asset exists in the specified location.Verification successful
Sprite Path Verification Successful
The sprite path for the Plating tile is correct, and the asset
plating.pngexists in the specified directoryResources/Textures/White/Tiles. No further action is needed.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the existence of the updated sprite path for the Plating tile. fd 'plating.png' Resources/Textures/White/Tiles --exec echo "Found: {}"Length of output: 121
112-123: Add new tile PlatingDiagonalNE.A new tile type
PlatingDiagonalNEhas been added with its properties. Ensure the sprite path is correct and that the tile functions as expected in the application.
125-136: Add new tile PlatingDiagonalNW.A new tile type
PlatingDiagonalNWhas been added. Verify the sprite path and ensure the tile's integration within the application.
138-149: Add new tile PlatingDiagonalSE.A new tile type
PlatingDiagonalSEhas been added. Check the sprite path and confirm the tile's functionality within the application.
151-161: Add new tile PlatingDiagonalSW.A new tile type
PlatingDiagonalSWhas been added. Ensure the sprite path is correct and that the tile is properly integrated into the application.Resources/Prototypes/Entities/Structures/Wallmounts/monitors_televisions.yml (2)
146-146: Add shader property to WallmountTelevisionFrame.The
shader: unshadedproperty has been added to thecomputerLayerScreenlayer. Ensure that this property is supported and functions as expected in the rendering pipeline.
140-140: Update sprite path for WallmountTelevisionFrame.The sprite path has been updated. Verify the new path to ensure the asset is correctly categorized and available.
Verification successful
Sprite path verified successfully.
The sprite path
White/Structures/Wallmounts/flatscreentv.rsiexists and is correctly categorized underResources/Textures/White/Structures/Wallmounts. No further action is needed.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the existence of the updated sprite path for WallmountTelevisionFrame. fd 'flatscreentv.rsi' Resources/Textures/White/Structures/Wallmounts --exec echo "Found: {}"Length of output: 163
Resources/Prototypes/_White/Decals/trim_markings.yml (1)
1-255: Decal definitions look good.The decal definitions are consistent and well-structured. The use of
defaultCustomColorfor greyscale decals is appropriate.Resources/Prototypes/Entities/Structures/Storage/Closets/base_structureclosets.yml (2)
127-127: Sprite path updates are correct.The sprite paths have been updated to include the
White/prefix, aligning with the reorganization of assets.Also applies to: 190-190, 222-222
Line range hint
1-255: Entity definitions are consistent and well-structured.The entity definitions are complete and correctly structured.
Resources/Prototypes/_White/Decals/trim.yml (1)
1-356: Decal definitions are consistent and well-structured.The decal definitions are complete and correctly structured.
Resources/Prototypes/Entities/Structures/Furniture/chairs.yml (3)
359-361: LGTM!The addition of the
spriteandnoRotproperties forUnanchoredChairBaseenhances the visual representation and behavior of the chair entity.
396-396: LGTM!The
spriteproperty update forRitualSeatstandardizes the visual representation of the chair entity.
421-421: LGTM!The
spriteproperty update for thecursedchair maintains consistency in the visual representation of chair entities.Resources/Prototypes/_White/Entities/Structures/Furniture/random_potted_plants.yml (5)
3-22: LGTM!The configuration for
RandomPottedPlantBaseis well-structured, providing a solid base for derived entities with interesting gameplay mechanics.
24-39: LGTM!The
RandomPottedPlantSpawneris effectively set up to introduce randomness in plant spawning, enhancing gameplay variability.
43-105: LGTM!The
RandomPottedTinyPlantentity is comprehensively configured, providing detailed attributes for a tiny plant entity.
229-305: LGTM!The
RandomPottedSmallPlantentity is well-configured, maintaining consistency with other plant entities while accommodating size variations.
484-543: LGTM!The
RandomPottedMediumPlantentity is thoroughly configured, providing a consistent and detailed setup for a medium-sized plant.Resources/Locale/ru-RU/ss14-ru/prototypes/entities/structures/wallmounts/signs/signs.ftl (5)
2-2: LGTM!The updated description for
ent-PaintingMonkeyenhances clarity and engagement.
6-6: LGTM!The suffix update for
ent-BaseSignDirectionalstandardizes naming conventions, enhancing consistency.
31-33: LGTM!The addition of
ent-SignDirectionalExamexpands the range of signs, enhancing navigational clarity.
94-96: LGTM!The addition of
ent-SignAnomaly2provides additional guidance for anomaly labs, enhancing user navigation.
46-48: LGTM!The updated description for
ent-SignDirectionalHopimproves clarity and formality.Resources/Prototypes/Entities/Structures/Wallmounts/switch.yml (5)
55-55: Verify shader property impact.The
shader: unshadedproperty has been added. Ensure this change is intentional and verify its impact on rendering.Also applies to: 153-153, 565-565
Verification successful
Shader property usage is consistent.
The
shader: unshadedproperty is used extensively across various entities in the codebase, indicating a consistent design choice. Its addition inswitch.ymlaligns with this pattern and appears intentional. No issues found.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of the `shader: unshaded` property on rendering. # Test: Search for the usage of `shader: unshaded` in other entities to understand its impact. rg 'shader: unshaded' --type yamlLength of output: 53438
580-601: Verify new entity identifiers and structure.New entities have been introduced. Ensure their identifiers are unique and consistent with existing naming conventions.
Also applies to: 602-611, 612-621, 622-631, 632-644, 646-655
Verification successful
Entity identifiers are unique and consistent.
The entity identifiers in the
switch.ymlfile are unique and follow a consistent naming pattern with distinct suffixes. No issues found regarding duplication or naming inconsistencies.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the uniqueness of new entity identifiers. # Test: Check for duplicate identifiers in the entities file. rg 'id: ButtonFrame' --type yamlLength of output: 3202
562-565: Verify layer additions for exit states.Layers have been added for exit states. Ensure they are correctly implemented and function as intended.
527-527: Verify suffix consistency.Suffixes have been modified to include numbers. Ensure consistency and correctness across all entities.
Also applies to: 537-537, 547-547, 557-557, 571-571
53-53: Verify new sprite paths.The sprite paths have been updated to
White/Structures/Wallmounts. Ensure that these paths are correct and that the assets exist in the new location.Also applies to: 92-92, 151-151, 253-253
Verification successful
Sprite paths are correctly updated.
The sprite files
switch.rsiandlocked_switch.rsiexist in theResources/Textures/White/Structures/Wallmounts/directory, confirming that the updated paths in the YAML file are correct and consistent with the project's asset organization. No further action is required.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of updated sprite paths. # Test: Check if the new sprite paths exist in the repository. fd 'switch.rsi' --base-directory 'White/Structures/Wallmounts' fd 'locked_switch.rsi' --base-directory 'White/Structures/Wallmounts'Length of output: 308
Script:
#!/bin/bash # Description: Verify the existence of updated sprite paths by searching the entire repository. # Test: Search for the sprite files in the entire repository. fd 'switch.rsi' fd 'locked_switch.rsi'Length of output: 402
Resources/Prototypes/Entities/Objects/Misc/tiles.yml (4)
216-231: Verify new tile entity identifiers and structure.New tile entities have been introduced. Ensure their identifiers are unique and consistent with existing naming conventions.
Also applies to: 232-247, 248-263, 1190-1200, 1201-1212
Verification successful
Tile entity identifier is unique and correctly structured.
The identifier
FloorTileItemLinoWhitefor the new tile entity is unique within the codebase, and its structure is consistent with existing naming conventions. No duplicates were found.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the uniqueness of new tile entity identifiers. # Test: Check for duplicate identifiers in the tiles file. rg 'id: FloorTileItem' --type yamlLength of output: 7720
1321-1332: Verify specialized tile entity behaviors.Specialized tile entities with unique behaviors have been added. Ensure that destructible properties and sound effects are correctly implemented.
Also applies to: 1381-1411
1237-1248: Verify new plastic tile entity identifiers and structure.New plastic tile entities have been introduced. Ensure their identifiers are unique and consistent with existing naming conventions.
Also applies to: 1249-1260, 1261-1272, 1273-1284, 1285-1296, 1297-1308, 1309-1320
Verification successful
Identifiers for new plastic tile entities are unique and consistent.
The identifiers for the new plastic tile entities are unique and follow the existing naming conventions. No duplicates were found.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the uniqueness of new plastic tile entity identifiers. # Test: Check for duplicate identifiers in the tiles file. rg 'id: FloorTileItemPlastic' --type yamlLength of output: 634
8-8: Verify new sprite paths.The sprite paths have been updated to
White/Objects/Tiles/tile.rsi. Ensure that these paths are correct and that the assets exist in the new location.Also applies to: 10-10
Verification successful
Sprite path verified successfully.
The sprite path
White/Objects/Tiles/tile.rsiis correct and the corresponding asset exists in the repository atResources/Textures/White/Objects/Tiles/tile.rsi. No further action is required.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of updated sprite paths. # Test: Check if the new sprite paths exist in the repository. fd 'tile.rsi' --base-directory 'White/Objects/Tiles'Length of output: 132
Script:
#!/bin/bash # Description: Search for the 'tile.rsi' file in the entire repository to verify its existence. # Use fd to search for 'tile.rsi' across the entire repository. fd 'tile.rsi'Length of output: 237
Resources/Prototypes/Entities/Structures/Wallmounts/Signs/signs.yml (2)
248-267: New sign entities added.The new sign entities have been added with consistent properties and a standardized sprite file. This improves the maintainability and visual consistency of the signs.
Ensure that the sprite file
White/Structures/Wallmounts/signs.rsiexists and is correctly configured to support these new entities.Also applies to: 357-376, 415-424, 513-522, 573-582, 613-622, 661-680, 718-737, 758-767, 768-777, 858-867, 887-896, 897-906, 1025-1034, 1035-1044, 1055-1064, 1065-1074
Verification successful
Sprite file verification successful.
The sprite file
signs.rsiexists in the repository, confirming that the new sign entities are correctly configured with the necessary resources.
- Locations of
signs.rsi:
Resources/Textures/White/Structures/Wallmounts/signs.rsi/Resources/Textures/Structures/Wallmounts/signs.rsi/Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of the sprite file used in new entities. # Test: Check if the sprite file exists. Expect: File should exist. fd 'signs.rsi' --path White/Structures/WallmountsLength of output: 265
Script:
#!/bin/bash # Description: Verify the existence of the sprite file used in new entities. # Test: Check if the sprite file exists. Expect: File should exist. fd 'signs.rsi' White/Structures/WallmountsLength of output: 157
Script:
#!/bin/bash # Description: Verify the existence of the sprite file used in new entities. # Test: Search for the sprite file across the entire repository. fd 'signs.rsi'Length of output: 124
245-246: Updated sign entities with standardized sprite property.The existing sign entities have been updated to include a standardized sprite property, enhancing consistency and simplifying future updates.
Ensure that the sprite file
White/Structures/Wallmounts/signs.rsiis up-to-date and correctly configured for these entities.Also applies to: 275-276, 285-286, 295-296, 305-306, 315-316, 325-326, 344-345, 354-355, 402-403, 412-413, 432-433, 442-443, 452-453, 462-463, 490-491, 500-501, 510-511, 530-531, 540-541, 560-561, 570-571, 600-601, 610-611, 639-640, 658-659, 688-689, 745-746, 755-756, 785-786, 795-796, 805-806, 815-816, 825-826, 835-836, 845-846, 855-856, 884-885, 914-915, 924-925, 934-935, 944-945, 954-955, 964-965, 992-993, 1002-1003, 1012-1013, 1022-1023, 1052-1053, 1082-1083, 1092-1093, 1102-1103, 1257-1258, 1267-1268, 1506-1507
Resources/Prototypes/Tiles/floors.yml (9)
4-4: Verify the new sprite path forFloorSteel.The sprite path has been updated to
/Textures/White/Tiles/steel.png. Ensure this path is correct and that the asset exists in the specified directory.Verification successful
Sprite path is correct for
FloorSteel.The sprite path
/Textures/White/Tiles/steel.pngis valid and corresponds to an existing file in the repository. No further action is needed.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of the new sprite path for `FloorSteel`. # Test: Check if the file exists at the new path. fd 'steel.png' -t f --search-path /Textures/White/Tiles/Length of output: 166
Script:
#!/bin/bash # Description: Search for the `steel.png` file across the entire repository. # Test: Find the actual location of `steel.png`. fd 'steel.png' -t fLength of output: 458
23-23: Verify the new sprite path forFloorSteelCheckerLight.The sprite path has been updated to
/Textures/White/Tiles/cafeteria.png. Ensure this path is correct and that the asset exists in the specified directory.Verification successful
Sprite Path Verification Successful
The sprite path
/Textures/White/Tiles/cafeteria.pngforFloorSteelCheckerLightis correct and the asset exists in the specified directory.
- Verified file location:
Resources/Textures/White/Tiles/cafeteria.pngScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of the new sprite path for `FloorSteelCheckerLight`. # Test: Check if the file exists at the new path. fd 'cafeteria.png' -t f --search-path /Textures/White/Tiles/Length of output: 170
Script:
#!/bin/bash # Description: Search for the 'cafeteria.png' file across the entire repository. # Test: Check if the file exists anywhere in the repository. fd 'cafeteria.png' -t fLength of output: 107
709-728: Verify properties for new tileFloorLinoWhite.The new tile
FloorLinoWhitehas specific properties defined. Ensure that these properties are consistent with other similar tile types and that the asset/Textures/White/Tiles/lino_white.pngexists.Verification successful
Verification of
FloorLinoWhiteProperties and AssetThe asset
/Textures/White/Tiles/lino_white.pngexists in the repository, confirming the sprite path is valid. Additionally, the properties ofFloorLinoWhitesuch asvariantsandplacementVariantsare consistent with other similar tile types likeFloorLinoGreyandFloorLinoDark, which also have 6 variants and similar placement variants.
- The asset
lino_white.pngis correctly located atResources/Textures/White/Tiles/lino_white.png.- The properties of
FloorLinoWhiteare consistent with other linoleum floor tiles.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the properties and asset existence for `FloorLinoWhite`. # Test: Check if the file exists at the new path. fd 'lino_white.png' -t f --search-path /Textures/White/Tiles/Length of output: 171
Script:
#!/bin/bash # Description: Verify the asset existence and property consistency for `FloorLinoWhite`. # Test: Search for the file `lino_white.png` across the entire repository. fd 'lino_white.png' -t f # Test: Extract similar tile types to compare properties. rg 'type: tile' -A 10 --glob '**/floors.yml'Length of output: 97577
2134-2151: Verify properties for new tileFloorAsteroidCoarse.The new tile
FloorAsteroidCoarsehas specific properties defined. Ensure that these properties are consistent with other similar tile types and that the asset/Textures/White/Tiles/Asteroid/asteroid_coarse.pngexists.Verification successful
Asset
asteroid_coarse.pngexists for tileFloorAsteroidCoarse.The asset
asteroid_coarse.pngreferenced in theFloorAsteroidCoarsetile definition is present in the repository atResources/Textures/White/Tiles/Asteroid/asteroid_coarse.png. This confirms that the sprite path is valid. No issues found with the asset reference.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the properties and asset existence for `FloorAsteroidCoarse`. # Test: Check if the file exists at the new path. fd 'asteroid_coarse.png' -t f --search-path /Textures/White/Tiles/Asteroid/Length of output: 194
Script:
#!/bin/bash # Description: Search for the file `asteroid_coarse.png` across the entire repository. # Test: Check if the file exists anywhere in the repository. fd 'asteroid_coarse.png' -t fLength of output: 89
1349-1358: Verify the new sprite path and variants forFloorSteelDamaged.The sprite path has been updated to
/Textures/White/Tiles/steel_damaged.png, and the number of variants has increased to 8. Ensure this path is correct and that the asset exists in the specified directory.Verification successful
Sprite path and variants update for
FloorSteelDamagedverified.The sprite file
steel_damaged.pngexists at the specified path/Textures/White/Tiles/steel_damaged.png, confirming the correctness of the update. The increase in variants to 8 is consistent with the change. No issues found.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of the new sprite path and variants for `FloorSteelDamaged`. # Test: Check if the file exists at the new path. fd 'steel_damaged.png' -t f --search-path /Textures/White/Tiles/Length of output: 174
Script:
#!/bin/bash # Description: Search for the sprite file `steel_damaged.png` in the entire repository. # Test: Check if the file exists anywhere in the repository. fd 'steel_damaged.png' -t fLength of output: 119
1372-1382: Verify the new sprite path and variants forFloorSteelBurnt.The sprite path has been updated to
/Textures/White/Tiles/steel_burnt.png, and the number of variants has increased to 8. Ensure this path is correct and that the asset exists in the specified directory.Verification successful
Sprite path and variants for
FloorSteelBurntare correct.The sprite file
steel_burnt.pngexists at the specified path/Textures/White/Tiles/steel_burnt.png, confirming the correctness of the sprite path. The increase in variants to 8 is noted and does not raise any issues.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of the new sprite path and variants for `FloorSteelBurnt`. # Test: Check if the file exists at the new path. fd 'steel_burnt.png' -t f --search-path /Textures/White/Tiles/Length of output: 172
Script:
#!/bin/bash # Description: Search for the sprite file `steel_burnt.png` in the entire repository. # Test: Find the file `steel_burnt.png` anywhere in the repository. fd 'steel_burnt.png' -t fLength of output: 113
2388-2388: Verify the new sprite path forFloorReinforcedHardened.The sprite path has been updated to
/Textures/White/Tiles/super_reinforced.png. Ensure this path is correct and that the asset exists in the specified directory.Verification successful
Sprite Path Verified for
FloorReinforcedHardened.The sprite file
super_reinforced.pngexists in the codebase at the following locations:
Resources/Textures/White/Tiles/super_reinforced.pngResources/Textures/Tiles/super_reinforced.pngThe path specified in the YAML file is correct and points to an existing asset.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of the new sprite path for `FloorReinforcedHardened`. # Test: Check if the file exists at the new path. fd 'super_reinforced.png' -t f --search-path /Textures/White/Tiles/Length of output: 177
Script:
#!/bin/bash # Description: Search for the sprite file `super_reinforced.png` from the root of the repository. # Search for the file across the entire repository. fd 'super_reinforced.png' -t fLength of output: 128
2477-2477: Verify the new sprite path forFloorWoodLarge.The sprite path has been updated to
/Textures/White/Tiles/wood_large.png. Ensure this path is correct and that the asset exists in the specified directory.Verification successful
Sprite path is valid for
FloorWoodLarge.The file
wood_large.pngexists at the specified pathResources/Textures/White/Tiles/wood_large.png, confirming that the sprite path is correct. No further action is needed.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of the new sprite path for `FloorWoodLarge`. # Test: Check if the file exists at the new path. fd 'wood_large.png' -t f --search-path /Textures/White/Tiles/Length of output: 171
Script:
#!/bin/bash # Description: Search for the file 'wood_large.png' across the entire repository. # Test: Check if the file exists anywhere in the repository. fd 'wood_large.png' -t fLength of output: 110
901-918: Verify properties for new tileFloorSteelYellow.The new tile
FloorSteelYellowhas specific properties defined. Ensure that these properties are consistent with other similar tile types and that the asset/Textures/White/Tiles/steel_yellow.pngexists.Verification successful
Properties for
FloorSteelYelloware consistent with other tile types.The properties of the new tile
FloorSteelYelloware consistent with other similar tile types in the repository. The asset/Textures/White/Tiles/steel_yellow.pngexists, confirming the reference is correct. The attributes such asbaseTurf,variants, andplacementVariantsalign with other entries. No issues were found.
- The asset
steel_yellow.pngis located atResources/Textures/White/Tiles/steel_yellow.png.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the properties and asset existence for `FloorSteelYellow`. # Test: Check if the file exists at the new path. fd 'steel_yellow.png' -t f --search-path /Textures/White/Tiles/Length of output: 173
Script:
#!/bin/bash # Description: Search for the `steel_yellow.png` file across the entire repository. # Search for the file `steel_yellow.png` in the repository. fd 'steel_yellow.png' -t fLength of output: 74
Script:
#!/bin/bash # Description: Extract and compare properties of similar tile types in YAML files. # Find all YAML files in the repository and extract tile definitions. fd -e yml | xargs rg 'type: tile' -A 10Length of output: 117164
| tags: ["station", "markings"] | ||
| sprite: | ||
| sprite: White/Decals/window_frame.rsi | ||
| state: frame_line_w No newline at end of file |
There was a problem hiding this comment.
Add a newline at the end of the file.
The file lacks a newline character at the end, which is a minor formatting issue. Adding a newline can improve compatibility with various tools and editors.
+ Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| state: frame_line_w | |
| state: frame_line_w | |
Tools
yamllint
[error] 118-118: no new line character at the end of file
(new-line-at-end-of-file)
PIVA BLYAD V GORSHOK MNE
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- Resources/Prototypes/_White/Entities/Structures/Furniture/random_potted_plants.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- Resources/Prototypes/_White/Entities/Structures/Furniture/random_potted_plants.yml
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
3 participants
Хуйня пока без ченжлога.
Перед мёржем прогнать тесты.
Summary by CodeRabbit
New Features
Bug Fixes
Chores