Skip to content

fix templating of cli_args values in helm chart #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shortstories wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix templating of cli_args values in helm chart #20

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c493356
fix templating of `cli_args` values #19
shortstories Mar 11, 2025
b6132c8
Merge remote-tracking branch 'upstream/master' into fix-cli-args
shortstories Sep 19, 2025
52394c7
fix templating of cli_args values #19
shortstories Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/redisoperator/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ spec:
- name: {{ .Chart.Name }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion}}"
{{- if .Values.image.cli_args }}
args:
- {{ quote .Values.image.cli_args }}
args:
{{- toYaml .Values.image.cli_args | nindent 8 }}
Copy link

Copilot AI Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The toYaml function will render cli_args as YAML, but the args field in Kubernetes expects a list of strings. If cli_args is already a YAML list, this will create nested YAML structure. Consider using {{- range .Values.image.cli_args }} with {{ . | quote }} for each item, or ensure cli_args contains pre-formatted string values.

Suggested change
{{- toYaml .Values.image.cli_args | nindent 8 }}
{{- range .Values.image.cli_args }}
{{- . | quote }}
{{- end }}

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown

@samof76 samof76 Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shortstories can you please check if you are ok with this?

Copy link
Copy Markdown
Author

@shortstories shortstories Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samof76
ok. applied and committed.
There was an error in the Copilot review, so I fixed that part as well.

{{- end }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
ports:
Expand Down