fix templating of cli_args values in helm chart#20
Conversation
|
Thanks. This major rewamp PR is pending, will take it after that. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the templating of cli_args values in the Helm chart deployment configuration. The change corrects how command-line arguments are rendered in the Kubernetes deployment YAML, replacing improper quoting with proper YAML list formatting.
- Replaces incorrect
quotefunction usage with proper YAML list templating for CLI arguments
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| args: | ||
| - {{ quote .Values.image.cli_args }} | ||
| args: | ||
| {{- toYaml .Values.image.cli_args | nindent 8 }} |
There was a problem hiding this comment.
The toYaml function will render cli_args as YAML, but the args field in Kubernetes expects a list of strings. If cli_args is already a YAML list, this will create nested YAML structure. Consider using {{- range .Values.image.cli_args }} with {{ . | quote }} for each item, or ensure cli_args contains pre-formatted string values.
| {{- toYaml .Values.image.cli_args | nindent 8 }} | |
| {{- range .Values.image.cli_args }} | |
| {{- . | quote }} | |
| {{- end }} |
There was a problem hiding this comment.
@shortstories can you please check if you are ok with this?
There was a problem hiding this comment.
@samof76
ok. applied and committed.
There was an error in the Copilot review, so I fixed that part as well.
Fixes #19
Changes proposed on the PR:
cli_argsvalues