Skip to content

Fix skipped texts. #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
polina-c wants to merge 5 commits into
base: main
Choose a base branch
from
+74 −4
Open

Fix skipped texts. #1023

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
012c0df
Update chat_session.dart
polina-c Aug 12, 2026
08d7e96
Update examples/simple_chat/lib/chat_session.dart
polina-c Aug 12, 2026
f1a4b1f
Create chat_session_test.dart
polina-c Aug 12, 2026
d6223d8
Update chat_session.dart
polina-c Aug 12, 2026
9812eed
Merge remote-tracking branch 'refs/remotes/origin/fix-disappeared-mes…
polina-c Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions examples/simple_chat/lib/chat_session.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,13 @@ sealed class ChatSession extends ChangeNotifier {
}

Future<void> _runRequest(Future<void> Function() body) async {
// The response streams in through `_updateAiMessage`, which starts a new
// bubble when `_currentAiMessage` is null and appends to that bubble
// otherwise. Clearing it here is what gives the coming response a bubble of
// its own. Every request runs through here, both typed messages and the
// ones a surface submits when the user taps a button, so a button's reply
// does not end up appended to the previous response.
_currentAiMessage = null;
_isProcessing = true;
Comment thread
polina-c marked this conversation as resolved.
notifyListeners();
Comment thread
polina-c marked this conversation as resolved.
try {
Expand Down Expand Up @@ -164,7 +171,6 @@ class TextOnlyChatSession extends ChatSession {
Future<void> sendMessage(String text) async {
if (text.isEmpty) return;

_currentAiMessage = null;
_addUserMessage(text);

await _runRequest(
Expand Down Expand Up @@ -236,9 +242,6 @@ class A2uiChatSession extends ChatSession {
Future<void> sendMessage(String text) async {
if (text.isEmpty) return;

// Reset current AI message so new response gets a new bubble
_currentAiMessage = null;

_addUserMessage(text);

await _runRequest(() => _transport.sendRequest(ChatMessage.user(text)));
Expand Down
Loading