-
Notifications
You must be signed in to change notification settings - Fork 170
Fix skipped texts. #1023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
polina-c
wants to merge
5
commits into
flutter:main
Choose a base branch
from
polina-c:fix-disappeared-messages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+74
−4
Open
Fix skipped texts. #1023
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
012c0df
Update chat_session.dart
polina-c 08d7e96
Update examples/simple_chat/lib/chat_session.dart
polina-c f1a4b1f
Create chat_session_test.dart
polina-c d6223d8
Update chat_session.dart
polina-c 9812eed
Merge remote-tracking branch 'refs/remotes/origin/fix-disappeared-mes…
polina-c File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| // Copyright 2025 The Flutter Authors. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import 'package:flutter_test/flutter_test.dart'; | ||
| import 'package:simple_chat/chat_session.dart'; | ||
| import 'package:simple_chat/primitives/message.dart'; | ||
|
|
||
| import 'fake_ai_client.dart'; | ||
|
|
||
| void main() { | ||
| test('a request started while one is in flight is ignored', () async { | ||
| final fakeAiClient = FakeAiClient() | ||
| ..addResponse('The first response, long enough to arrive in chunks.') | ||
| ..addResponse('The second response.'); | ||
| final session = TextOnlyChatSession(aiClient: fakeAiClient); | ||
| addTearDown(session.dispose); | ||
|
|
||
| // The app disables its text input while a request is in flight, but a | ||
| // rendered surface stays interactive, so its buttons can submit at any | ||
| // point. Both routes end up in the same place, so send a second message | ||
| // without awaiting the first. | ||
| final Future<void> first = session.sendMessage('one'); | ||
| await session.sendMessage('two'); | ||
| await first; | ||
|
|
||
| // The second request never reached the agent. | ||
| expect(fakeAiClient.receivedPrompts, ['one']); | ||
|
|
||
| // The first response arrived in a single bubble, rather than being split in | ||
| // two by the second request clearing the current message mid-stream. | ||
| final List<Message> replies = session.messages | ||
| .where((message) => !message.isUser) | ||
| .toList(); | ||
| expect(replies, hasLength(1)); | ||
| expect( | ||
| replies.single.text, | ||
| 'The first response, long enough to arrive in chunks.', | ||
| ); | ||
|
|
||
| // The in-flight request owns the progress state until it finishes. | ||
| expect(session.isProcessing, isFalse); | ||
| }); | ||
|
|
||
| test('requests run one after another when awaited', () async { | ||
| final fakeAiClient = FakeAiClient() | ||
| ..addResponse('First.') | ||
| ..addResponse('Second.'); | ||
| final session = TextOnlyChatSession(aiClient: fakeAiClient); | ||
| addTearDown(session.dispose); | ||
|
|
||
| await session.sendMessage('one'); | ||
| await session.sendMessage('two'); | ||
|
|
||
| expect(fakeAiClient.receivedPrompts, ['one', 'two']); | ||
|
|
||
| // Each response gets a bubble of its own. | ||
| expect( | ||
| session.messages.where((message) => !message.isUser).map((m) => m.text), | ||
| ['First.', 'Second.'], | ||
| ); | ||
| }); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.