-
Notifications
You must be signed in to change notification settings - Fork 8
Support for rmd notebooks #1941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
143e547
feat(formats): add base structure for file format adapters - #1931
gigalasr bca3700
feat(formats): basic adapter for rmd - #1931
gigalasr 59c21c1
feat(formats): parse options and inline code blocks - #1931
gigalasr e41f90a
feat(format): use rmd parser in rshell as well - #1931
gigalasr b5e36b6
feat(rmd): reconstructor code block at correct position - #1931
gigalasr 9090cb3
refactor(rmd): suggestion from code review - #1931
gigalasr 4ef2dc4
refactor(adapter): make adapters work on Request layer - #1931
gigalasr 3510448
test-fix(rmd): cleanup test - #1931
gigalasr 5e40130
feat(rmd): add newlines at the end to match the entire file - #1931
gigalasr 5e43eb2
refactor(rmd): use map to map from extension to Format - #1931
gigalasr b7527c0
refactor(rmd): create file requests with adapter - #1931
gigalasr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import type { RParseRequest } from '../../r-bridge/retriever'; | ||
|
||
export interface FileAdapter { | ||
convertRequest(request: RParseRequest): RParseRequest | ||
} | ||
|
||
export type SupportedFormats = 'R' | 'Rmd'; | ||
|
||
export type SupportedDocumentTypes = '.r' | '.rmd'; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.