Support for rmd notebooks #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

EagleoutIce merged 11 commits into main from 1931-support-for-notebooks-rmd-etc

Sep 23, 2025

Collaborator

gigalasr commented Sep 16, 2025

No description provided.

gigalasr added 3 commits

September 16, 2025 11:37


          feat(formats): add base structure for file format adapters - #1931

143e547


          feat(formats): basic adapter for rmd - #1931

bca3700


          feat(formats): parse options and inline code blocks - #1931

59c21c1

gigalasr linked an issue

that may be closed by this pull request

Support for Notebooks, Rmd etc. #1931

Closed

gigalasr added 2 commits

September 16, 2025 15:22


          feat(format): use rmd parser in rshell as well - #1931

e41f90a


          feat(rmd): reconstructor code block at correct position - #1931

b5e36b6

gigalasr self-assigned this

EagleoutIce reviewed

View reviewed changes

src/r-bridge/retriever.ts Outdated Show resolved Hide resolved

EagleoutIce reviewed

View reviewed changes

src/util/formats/adapter.ts Outdated Show resolved Hide resolved

EagleoutIce reviewed

View reviewed changes

src/util/formats/adapters/r-adapter.ts Outdated Show resolved Hide resolved

EagleoutIce reviewed

View reviewed changes

src/util/formats/adapters/rmd-adapter.ts Outdated Show resolved Hide resolved

EagleoutIce reviewed

View reviewed changes

src/util/formats/adapters/rmd-adapter.ts Outdated Show resolved Hide resolved

EagleoutIce reviewed

View reviewed changes

src/util/formats/adapters/rmd-adapter.ts Outdated Show resolved Hide resolved

EagleoutIce reviewed

View reviewed changes

src/util/formats/adapters/rmd-adapter.ts Outdated Show resolved Hide resolved

EagleoutIce reviewed

View reviewed changes

src/util/formats/adapters/rmd-adapter.ts Outdated Show resolved Hide resolved

EagleoutIce reviewed

View reviewed changes

Member

EagleoutIce left a comment

very nice :)

EagleoutIce mentioned this pull request

Basic telemetry system (+ webpack bundling for desktop) flowr-analysis/vscode-flowr#316

Merged


          refactor(rmd): suggestion from code review - #1931

9090cb3

Member

EagleoutIce commented Sep 20, 2025

one additional thing i noticed, a simple step that we could also make configurable for this stage (or as a subsequent issue) is that each cell becomes its "own file" for flowR - this way we do not have to add additional logic to handle notebook specific execution semantics


          refactor(adapter): make adapters work on Request layer - #1931

4ef2dc4

gigalasr marked this pull request as ready for review

September 21, 2025 15:42


          test-fix(rmd): cleanup test - #1931

EagleoutIce approved these changes

View reviewed changes

src/benchmark/slicer.ts Outdated Show resolved Hide resolved

src/cli/slicer-app.ts Outdated Show resolved Hide resolved

src/cli/slicer-app.ts Show resolved Hide resolved

src/r-bridge/lang-4.x/tree-sitter/tree-sitter-executor.ts Outdated Show resolved Hide resolved

src/util/formats/adapter.ts Outdated Show resolved Hide resolved

src/util/formats/adapters/rmd-adapter.ts Outdated Show resolved Hide resolved

test/testfiles/notebook/example.Rmd Show resolved Hide resolved

gigalasr added 3 commits

September 22, 2025 17:22


          feat(rmd): add newlines at the end to match the entire file - #1931

5e40130


          refactor(rmd): use map to map from extension to Format - #1931

5e43eb2


          refactor(rmd): create file requests with adapter - #1931

b7527c0

EagleoutIce approved these changes

View reviewed changes

EagleoutIce merged commit 029230a into main

19 checks passed

EagleoutIce deleted the 1931-support-for-notebooks-rmd-etc branch

September 23, 2025 19:02

Member

EagleoutIce commented Sep 23, 2025

This pull request is included in v2.5.0 (see Release v2.5.0 (RMarkdown Adapter)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet