EDM-4063: Add docker:// protocol if link does not contain any

[rawagner]

No description provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 096c97ec-3a56-4bd1-90a2-6f5c58ed1671

📥 Commits

Reviewing files that changed from the base of the PR and between 97f0434 and 0acdacd.

📒 Files selected for processing (1)

• libs/ui-components/src/components/Catalog/InstallWizard/steps/SelectTargetStep.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

• libs/ui-components/src/components/Catalog/InstallWizard/steps/SelectTargetStep.tsx

---

Summary by CodeRabbit

• Bug Fixes
  • Installation wizard download button now detects existing URL protocols and correctly prefixes artifact links (e.g., with docker://) when needed, ensuring download links open correctly.

Walkthrough

SelectTargetStep.tsx adds protocol detection to artifact URLs. A PROTOCOL_REGEX constant identifies URLs with explicit protocols, and the download button's href conditionally prefixes docker:// only when no protocol is detected.

Changes

Protocol-aware download button

Layer / File(s)	Summary
Protocol detection and conditional URL prefix libs/ui-components/src/components/Catalog/InstallWizard/steps/SelectTargetStep.tsx	PROTOCOL_REGEX detects whether artifactUrl starts with a protocol. A computed hasProtocol boolean is used to conditionally prefix the button href with docker:// only when the URL lacks an explicit protocol.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to evaluate relevance to the changeset.	Add a pull request description explaining the purpose and context of this change for better clarity.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: adding docker:// protocol detection and prefixing when links lack an explicit protocol.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

libs/ui-components/src/components/Catalog/InstallWizard/steps/SelectTargetStep.tsx (1)

209-281: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Protocol regex misclassifies host:port image refs as “already has protocol.”

/^[a-zA-Z][a-zA-Z0-9+.-]*:/ matches localhost: in values like localhost:5000/my-image, so hasProtocol becomes true and Line 281 skips the docker:// prefix. That breaks the new behavior for common registry URLs without scheme.

Use stricter detection (e.g., require :// or a small allowlist of expected schemes) so host:port is treated as no-protocol.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@libs/ui-components/src/components/Catalog/InstallWizard/steps/SelectTargetStep.tsx`
around lines 209 - 281, The PROTOCOL_REGEX used by NewDeviceTarget
(PROTOCOL_REGEX and hasProtocol) incorrectly treats host:port (e.g.,
localhost:5000/...) as having a scheme; change the detection to require an
explicit scheme separator (e.g., "://") or match a small allowlist of known
schemes so that values like "localhost:5000/..." are considered no-protocol and
get the docker:// prefix; update PROTOCOL_REGEX and any uses of hasProtocol
(where artifactUrl is checked before building href) accordingly so only true
URIs (like "http://", "https://", "docker://", "oci://", etc.) bypass the
docker:// prepend.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In
`@libs/ui-components/src/components/Catalog/InstallWizard/steps/SelectTargetStep.tsx`:
- Around line 209-281: The PROTOCOL_REGEX used by NewDeviceTarget
(PROTOCOL_REGEX and hasProtocol) incorrectly treats host:port (e.g.,
localhost:5000/...) as having a scheme; change the detection to require an
explicit scheme separator (e.g., "://") or match a small allowlist of known
schemes so that values like "localhost:5000/..." are considered no-protocol and
get the docker:// prefix; update PROTOCOL_REGEX and any uses of hasProtocol
(where artifactUrl is checked before building href) accordingly so only true
URIs (like "http://", "https://", "docker://", "oci://", etc.) bypass the
docker:// prepend.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: b2d736dc-9312-43b7-a773-18caa7cda6eb

📥 Commits

Reviewing files that changed from the base of the PR and between afa4951 and 97f0434.

📒 Files selected for processing (1)

• libs/ui-components/src/components/Catalog/InstallWizard/steps/SelectTargetStep.tsx