[release-1.2] Backports for 1.2-rc2 (#674)

* EDM-4058: Correctly identify RBAC exclusions (#671)

Made-with: Cursor
(cherry picked from commit afa4951)

* EDM-3976 vulnerabilities empty state (#651)

* No need to return placeholder when no configs exist

Made-with: Cursor
(cherry picked from commit 15c4ddc)

* EDM-4008: Enforce only valid date range selection (#660)

Made-with: Cursor
(cherry picked from commit 5ee7434)

* EDM-4020: Refresh vulnerability summary in Overview (#657)

Made-with: Cursor
(cherry picked from commit 4204596)

* EDM-4063: Add docker:// protocol if link does not contain any (#675)

(cherry picked from commit 24c25bf)
Made-with: Cursor

* EDM-4014 device logs cancel (#659)

* EDM-4014: Add cancel button and improve overall UX
* EDM-4012: Reset filters when logType changes
* Fix disconnect banner for dark theme with suggested token

Made-with: Cursor
(cherry picked from commit 8c875e0)

* EDM-4018: Allow search for vulnerabilities be case-insensitive (#656)

* EDM-4018: Allow search for vulnerabilities be case-insensitive
* Fix space not being an allowed character

Made-with: Cursor
(cherry picked from commit 623d65a)

* EDM-4011: Fix parser missing footer depending on formatting (#663)

Made-with: Cursor
(cherry picked from commit 0ce4600)

* EDM-4013 device logs search validations (#662)

* EDM-4013: Block file paths with dots for moving away of /var/log
* EDM-4013: Strengthen validations for systemd unit names

Made-with: Cursor
(cherry picked from commit ac370df)

---------

Co-authored-by: Rastislav Wagner <rawagner@redhat.com>

Author: celdrake

libs/i18n/locales/en/translation.json

@@ -1631,6 +1631,9 @@
   "Total active vulnerabilities.": "Total active vulnerabilities.",
   "CVEs affecting images deployed across your managed fleet and devices.": "CVEs affecting images deployed across your managed fleet and devices.",
   "Vulnerability counts by severity": "Vulnerability counts by severity",
+  "No vulnerabilities were found affecting the image currently deployed on this device. This reflects the most recent scan data available.": "No vulnerabilities were found affecting the image currently deployed on this device. This reflects the most recent scan data available.",
+  "No vulnerabilities were found affecting images currently deployed across all devices in this fleet. This reflects the most recent scan data available.": "No vulnerabilities were found affecting images currently deployed across all devices in this fleet. This reflects the most recent scan data available.",
+  "No vulnerabilities detected": "No vulnerabilities detected",
   "No CVEs detected": "No CVEs detected",
   "All managed devices have been scanned. No CVEs were found affecting images currently deployed across your fleets and devices.": "All managed devices have been scanned. No CVEs were found affecting images currently deployed across your fleets and devices.",
   "No vulnerability data to display": "No vulnerability data to display",
@@ -1751,7 +1754,8 @@
   "Info and above": "Info and above",
   "Debug and above": "Debug and above",
   "Must be at most {{max}} characters.": "Must be at most {{max}} characters.",
-  "Enter a single unit name using alphanumeric characters, colons (:), at signs (@), dots (.), underscores (_), and hyphens (-).": "Enter a single unit name using alphanumeric characters, colons (:), at signs (@), dots (.), underscores (_), and hyphens (-).",
+  "Unit name must not consist of only dots.": "Unit name must not consist of only dots.",
+  "Enter a unit name or pattern. Use alphanumeric characters, dots (.), underscores (_), hyphens (-), at signs (@) and colons (:). Glob characters are allowed: (*, ?, [...]).": "Enter a unit name or pattern. Use alphanumeric characters, dots (.), underscores (_), hyphens (-), at signs (@) and colons (:). Glob characters are allowed: (*, ?, [...]).",
   "Log file path is required.": "Log file path is required.",
   "Log file path must be relative to {{basePath}}. It cannot be absolute or point outside the log directory.": "Log file path must be relative to {{basePath}}. It cannot be absolute or point outside the log directory.",
   "Log file path must not end with \"/\". Enter a file path, not a directory.": "Log file path must not end with \"/\". Enter a file path, not a directory.",

libs/ui-components/src/components/Catalog/InstallWizard/steps/SelectTargetStep.tsx

@@ -206,6 +206,8 @@ const FleetTarget = () => {
   );
 };
 
+const PROTOCOL_REGEX = /^[a-zA-Z][a-zA-Z0-9+.-]*:\/\//;
+
 type NewDeviceTargetProps = {
   catalogItem: CatalogItem;
 };
@@ -234,6 +236,8 @@ const NewDeviceTarget = ({ catalogItem }: NewDeviceTargetProps) => {
 
   const artifactUrl = currentVersion && artifact ? getFullArtifactURI(artifact, currentVersion) : undefined;
 
+  const hasProtocol = PROTOCOL_REGEX.test(artifactUrl || '');
+
   return (
     <FlightCtlForm>
       <Grid hasGutter>
@@ -274,7 +278,7 @@ const NewDeviceTarget = ({ catalogItem }: NewDeviceTargetProps) => {
                 icon={<ExternalLinkAltIcon />}
                 target="_blank"
                 rel="noopener noreferrer"
-                href={artifactUrl}
+                href={hasProtocol ? artifactUrl : `docker://${artifactUrl}`}
               >
                 {artifactUrl}
               </Button>

libs/ui-components/src/components/Device/DeviceDetails/DeviceLogsEmptyState.tsx

@@ -18,6 +18,12 @@ import { ExclamationCircleIcon } from '@patternfly/react-icons/dist/js/icons/exc
 import { DEVICE_LOG_BASE_PATH, DeviceLogErrorType } from '../../../utils/deviceLogs';
 import { useTranslation } from '../../../hooks/useTranslation';
 
+// Fixes the color of the text in the "red" banner button.
+const redBannerButtonFixStyle = {
+  '--pf-v6-c-button--m-link--Color': 'var(--pf-t--global--text--color--nonstatus--on-red--default)',
+  '--pf-v6-c-button--m-link--hover--Color': 'var(--pf-t--global--text--color--nonstatus--on-red--default)',
+} as React.CSSProperties;
+
 // Note: Despite the function signature, errorType can actually be a plain string.
 // This happens when we receive an uncontrolled error, and instead of the errorType we store the actual error message.
 const getErrorDetails = (t: TFunction, errorType: DeviceLogErrorType) => {
@@ -94,7 +100,7 @@ export const DeviceLogsDisconnectedBanner = ({ onRetry }: { onRetry: VoidFunctio
       <Flex justifyContent={{ default: 'justifyContentSpaceBetween' }}>
         <FlexItem>{t('Offline/ device lost connection')}</FlexItem>
         <FlexItem>
-          <Button variant="link" onClick={onRetry}>
+          <Button variant="link" onClick={onRetry} style={redBannerButtonFixStyle}>
             {t('Retry')}
           </Button>
         </FlexItem>

libs/ui-components/src/components/Device/DeviceDetails/DeviceLogsInnerToolbar.tsx

@@ -22,22 +22,31 @@ import {
   DeviceLogSearchParams,
   getActiveTimeFilterLabel,
   getDeviceLogLevelLabel,
+  getDeviceLogsFormResetValues,
 } from '../../../utils/deviceLogs';
 
 import './DeviceLogsInnerToolbar.css';
 
 export type DeviceLogsInnerToolbarProps = {
   lastSearchParams: DeviceLogSearchParams;
-  onSearchUpdate: (params: DeviceLogSearchParams) => Promise<boolean>;
-  onResetForm: VoidFunction;
+  isStreaming: boolean;
+  onApplySearchParams: (params: DeviceLogSearchParams) => Promise<boolean>;
+  onStartLiveStream: () => Promise<boolean>;
+  onStopLiveStream: VoidFunction;
+  onClearLiveLogsPreference: VoidFunction;
+  onClearSession: VoidFunction;
   onDownload: VoidFunction;
   onOpenRaw: VoidFunction;
 };
 
 const DeviceLogsInnerToolbar = ({
   lastSearchParams,
-  onSearchUpdate,
-  onResetForm,
+  isStreaming,
+  onApplySearchParams,
+  onStartLiveStream,
+  onStopLiveStream,
+  onClearLiveLogsPreference,
+  onClearSession,
   onDownload,
   onOpenRaw,
   children,
@@ -46,38 +55,31 @@ const DeviceLogsInnerToolbar = ({
   const { setValues, values } = useFormikContext<DeviceLogSearchParams>();
   const hasChildren = Boolean(children);
 
-  const updateLiveLogs = React.useCallback(
-    (checked: boolean) => {
-      const newParams = { ...lastSearchParams, showLiveLogs: checked };
-      void setValues(newParams);
-      return newParams;
-    },
-    [lastSearchParams, setValues],
-  );
+  const onClearSearch = React.useCallback(() => {
+    void setValues(getDeviceLogsFormResetValues(values.category));
+    onClearSession();
+  }, [onClearSession, setValues, values.category]);
 
-  // The "show live logs" switch can only be applied after the logs have been retrieved and it triggers a new search.
   const onShowLiveLogsChange = React.useCallback(
     (_event: React.FormEvent<HTMLInputElement>, checked: boolean) => {
-      const newParams = updateLiveLogs(checked);
-      void onSearchUpdate(newParams);
+      if (checked) {
+        void onStartLiveStream();
+      } else if (isStreaming) {
+        onStopLiveStream();
+      } else if (lastSearchParams.showLiveLogs) {
+        onClearLiveLogsPreference();
+      }
     },
-    [updateLiveLogs, onSearchUpdate],
+    [isStreaming, lastSearchParams.showLiveLogs, onClearLiveLogsPreference, onStartLiveStream, onStopLiveStream],
   );
 
-  const doResetForm = React.useCallback(() => {
-    updateLiveLogs(false);
-    onResetForm();
-  }, [onResetForm, updateLiveLogs]);
-
   const onRemoveFilter = React.useCallback(
     (filterKey: keyof DeviceLogSearchParams, defaultValue: string | undefined) => () => {
-      // We sync the form values with the search params with the current filter removed.
-      // That syncs the form controls to the updated search (including reverting non-persisted form changes)
       const newParams = { ...lastSearchParams, [filterKey]: defaultValue };
       void setValues(newParams);
-      void onSearchUpdate(newParams);
+      void onApplySearchParams(newParams);
     },
-    [onSearchUpdate, lastSearchParams, setValues],
+    [onApplySearchParams, lastSearchParams, setValues],
   );
 
   const activeFilters = React.useMemo(() => {
@@ -147,7 +149,7 @@ const DeviceLogsInnerToolbar = ({
                 </LabelGroup>
               </ToolbarItem>
               <ToolbarItem>
-                <Button variant="link" isInline onClick={doResetForm}>
+                <Button variant="link" isInline onClick={onClearSearch}>
                   {t('Clear search')}
                 </Button>
               </ToolbarItem>
@@ -157,7 +159,7 @@ const DeviceLogsInnerToolbar = ({
                 <Switch
                   id="device-logs-show-live-logs"
                   label={t('Show live logs')}
-                  isChecked={values.showLiveLogs}
+                  isChecked={isStreaming || lastSearchParams.showLiveLogs}
                   onChange={onShowLiveLogsChange}
                 />
               </ToolbarItem>

libs/ui-components/src/components/Device/DeviceDetails/DeviceLogsSearchToolbar.tsx

@@ -16,7 +16,12 @@ import {
 import { useFormikContext } from 'formik';
 
 import { useTranslation } from '../../../hooks/useTranslation';
-import { DEVICE_LOG_BASE_PATH, DeviceLogCategory, DeviceLogSearchParams } from '../../../utils/deviceLogs';
+import {
+  DEVICE_LOG_BASE_PATH,
+  DeviceLogCategory,
+  DeviceLogSearchParams,
+  getDeviceLogsFormResetValues,
+} from '../../../utils/deviceLogs';
 import FormSelect from '../../form/FormSelect';
 import TextField from '../../form/TextField';
 import DeviceLogsPriorityField from './DeviceLogsLevelField';
@@ -31,13 +36,24 @@ const getCategoryItems = (t: TFunction) => ({
 
 export type DeviceLogsToolbarProps = {
   onLogTypeChange: VoidFunction;
+  onCancelSearch: VoidFunction;
+  isSubmitting: boolean;
 };
 
-const DeviceLogsToolbar = ({ onLogTypeChange }: DeviceLogsToolbarProps) => {
+const DeviceLogsToolbar = ({ onLogTypeChange, isSubmitting, onCancelSearch }: DeviceLogsToolbarProps) => {
   const { t } = useTranslation();
   const categoryItems = React.useMemo(() => getCategoryItems(t), [t]);
 
-  const { submitForm, isSubmitting, values, errors } = useFormikContext<DeviceLogSearchParams>();
+  const { submitForm, setValues, values, errors } = useFormikContext<DeviceLogSearchParams>();
+
+  const onCategoryChange = React.useCallback(
+    (value: string) => {
+      void setValues(getDeviceLogsFormResetValues(value as DeviceLogCategory));
+      onLogTypeChange();
+    },
+    [onLogTypeChange, setValues],
+  );
+
   const validationError = React.useMemo(() => {
     const allErrors = Object.values(errors).filter(Boolean);
     return allErrors.join(', ');
@@ -63,7 +79,7 @@ const DeviceLogsToolbar = ({ onLogTypeChange }: DeviceLogsToolbarProps) => {
                   flexWrap={{ default: 'nowrap' }}
                 >
                   <FlexItem>
-                    <FormSelect name="category" items={categoryItems} onChange={onLogTypeChange} />
+                    <FormSelect name="category" items={categoryItems} onChange={onCategoryChange} />
                   </FlexItem>
                   {values.category === DeviceLogCategory.SYSTEM && (
                     <FlexItem style={{ minWidth: '12rem' }}>
@@ -108,6 +124,13 @@ const DeviceLogsToolbar = ({ onLogTypeChange }: DeviceLogsToolbarProps) => {
               </ToolbarItem>
             </ToolbarGroup>
             <ToolbarGroup variant="action-group" align={{ default: 'alignEnd' }}>
+              {isSubmitting && (
+                <ToolbarItem>
+                  <Button variant="link" onClick={onCancelSearch}>
+                    {t('Cancel')}
+                  </Button>
+                </ToolbarItem>
+              )}
               <ToolbarItem>
                 <Button
                   variant="primary"