Repository navigation
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Configure full-suite and targeted test lanes .github/workflows/pr-test.yml |
Adds full-suite and targeted RTX PRO 6000 entries using the rtx-pro-6000 runner, CUDA cu130, and task_run_unit_tests.sh. Targeted requests pass through the test runner’s path handling. |
Collect and analyze JUnit artifacts .github/workflows/pr-test.yml |
Uses matrix-kind JUnit artifact names for non-gpu lanes. Downloads RTX PRO 6000 artifacts and passes summary and JUnit-directory arguments for RTX PRO 6000 and H100 to skip-all analysis. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Possibly related issues
- flashinfer-ai/flashinfer#7118: Adds RTX PRO 6000 CI lanes relevant to the issue’s request for validation, but does not change backend dispatch or establish validation of the experimental backend.
Suggested reviewers: alex-ameen
Merge Risk: 
Minimal · up to 445ba
-
The workflow contracts align; runner availability remains an ordinary first-run validation concern, not a confirmed merge blocker.
Pre-merge checks: 
5
-
Full details: Description check
-
Explanation
The description follows the repository template and explains the implementation, related issue, test scope, known limitations, checklist status, and reviewer considerations. It also clearly states that the new lane has not yet run on g7e runners.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
@flashinfer-bot run |
Add full-suite and targeted RTX PRO 6000 lanes to PR Test, mirroring the H100 lanes. They run task_run_unit_tests.sh on cu130 on the on-demand g7e pool from flashinfer-ai/ci-infra#3 ([self-hosted, linux, x64, gpu, rtx-pro-6000, on-demand]). - Each g7e instance has one GPU, so the lane uses the single-runner cleanup and one test worker per GPU. - cu130 only: the pool's 595 driver cannot start the cu134 image, and cu129 is covered by the other GPU lanes. - JUnit artifacts for single-lane kinds are named by kind, and the summary job feeds the RTX run-summary.json to the skip-all check alongside H100's. AI-assisted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
83afeff to
445ba9a
Compare
|
@flashinfer-bot run |
📌 Description
This PR adds an RTX PRO 6000 (SM120) GPU lane to PR Test, set up like the H100 lane. It uses the on-demand g7e runner pool added in flashinfer-ai/ci-infra#3, with labels
[self-hosted, linux, x64, gpu, rtx-pro-6000, on-demand].New jobs
task_run_unit_tests.shsuite on cu130, with a 480-minute timeout (the same as H100).@flashinfer-bot run <paths>. Like H100, it takes the requested paths as-is, and tests skip themselves on archs they don't support.Ways it differs from H100
sm120. It targets thertx-pro-6000label so that a future GeForce SM120 pool can't pick up these jobs.Results
junit-h100-*,junit-rtx-pro-6000-*). The A10G/T4 names are unchanged.run-summary.jsontocheck_skip_all.pytogether with H100's. A changed test file that runs only on SM120 now counts as executed.🔍 Related Issues
gpu-g7e-ondemandrunner pool)🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues. (Ran on the changed file only; all hooks passed.)🧪 Tests
unittest, etc.).The step that builds the job list was run locally for both a full run and a targeted run (
tests/attention/test_hopper.py). Both produce the RTX PRO 6000 entry with the expected labels, CUDA version and test path. The lane has not yet run on the g7e runners; this PR's own CI run will be its first test.🔬 Experimental Track
flashinfer/experimental/and/or an@flashinfer_experimental_api. Tracking issue: #tests/experimental/and were validated on the intended hardware; a runnable example is included.flashinfer/aot.py, and no experimental backend is reachable frombackend="auto"withoutFLASHINFER_ALLOW_EXPERIMENTAL_AUTO_BACKENDS=1. (Calling an@flashinfer_experimental_apior naming a backend explicitly is itself the opt-in and needs no environment variable.)Reviewer Notes
🤖 Generated with Claude Code
Summary by CodeRabbit