Skip to content

add untie_embeddings_and_output_weights config #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chai-xiaonan wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

add untie_embeddings_and_output_weights config #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion megatron/core/transformer/transformer_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,9 @@ class TransformerConfig(ModelParallelConfig):
"""Number of SMs to use for HybridEP. In pure NVL scenarios,
16 SMs can generally achieve good bandwidth."""

untie_embeddings_and_output_weights: bool = False
"""The model's input word embedding matrix and the output layer's weight matrix are tied"""

####################
# initialization
####################
Expand Down Expand Up @@ -787,7 +790,6 @@ class TransformerConfig(ModelParallelConfig):
lora_out_init_method: Optional[str] = None
"""Lora b init method"""


####################
# TE_FL
####################
Expand Down