add untie_embeddings_and_output_weights config#7
Open
chai-xiaonan wants to merge 1 commit intoflagos-ai:mainfrom
Open
add untie_embeddings_and_output_weights config#7chai-xiaonan wants to merge 1 commit intoflagos-ai:mainfrom
chai-xiaonan wants to merge 1 commit intoflagos-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to solve the problem that the newly added nemo-bridge function in flagscale fails to obtain the 'untie_embeddings_and_output_weights' parameter configuration when processing the mcore-model, by adding this option, the problem can be permanently resolved. This will enable the acquisition of the parameters of the mcore-model when converting from the hf format to the mcore-model or when converting from the mcore-model to the hf format, and then corresponding processing of the model weights can be carried out.