Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
A public patch uses Node.js 20 and the Node suites that match the change.
You do not need the agent harness or a task session directory.

- [ ] `npm run test:broker-core` / `npm run test:client` / `npm run test:harness-adoption` as applicable, or I explained why a deterministic test is not available
- [ ] `npm run test:broker-core` / `npm run test:client` / `npm run test:harness-adoption` / `npm run test:docs` as applicable, or I explained why a deterministic test is not available
- [ ] I did not commit private paths, credentials, generated Xcode projects, local broker state, or task-session artifacts

## Notes
Expand Down
5 changes: 3 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,9 @@ npm run test:harness-adoption
Run `npm run test:docs` for doc, README, or template changes; it runs the `docs/test` front-door checks.

App work also needs XcodeGen and `npm run test:app`. The full suite is
`npm test`. The same Node suites run on GitHub-hosted Ubuntu CI. That job
does not run `npm run test:app`.
`npm test`. GitHub-hosted Ubuntu CI runs public-surface, `test:broker-core`,
`test:client`, and `test:harness-adoption`. That job does not run
`npm run test:app` or `npm run test:docs`.

You do not need to run `agent:context`, `agent:verify`, or `agent:complete`,
and you do not need to create a task session directory.
Expand Down
6 changes: 6 additions & 0 deletions docs/test/front-door.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,11 @@ test("CONTRIBUTING leads with a public Node-20 patch track that does not require
|| human.includes("npm test"),
"public track must name a Node test command that is not agent:*",
);
assert.ok(human.includes("npm run test:docs"), "public track must name test:docs");
assert.ok(
human.includes("does not run") && human.includes("npm run test:docs"),
"public track must not claim Ubuntu CI runs test:docs",
);
assert.equal(human.includes("You do not need to run `agent:context`"), true);
assert.equal(human.includes("$HOME/.codex"), false);
assert.equal(human.includes("npm run agent:context --"), false);
Expand Down Expand Up @@ -277,6 +282,7 @@ test("PR template is a public-patch checklist and does not require the harness",
assert.ok(template.includes("npm run test:broker-core"));
assert.ok(template.includes("npm run test:client"));
assert.ok(template.includes("npm run test:harness-adoption"));
assert.ok(template.includes("npm run test:docs"));
assert.ok(template.includes("Alpha"));
assert.ok(template.includes("macOS"));
assert.ok(template.includes("Xcode"));
Expand Down
Loading