Tell public patches that Ubuntu CI does not run test:docs - #16
Merged
Conversation
Why: PR 11 added npm run test:docs and listed it with the other public Node suites. CONTRIBUTING still said those same suites run on Ubuntu CI and in npm test. The PR template also omitted test:docs. Changed: CONTRIBUTING now lists the Ubuntu CI Node suites and says that job skips test:app and test:docs. The PR template checklist includes test:docs. Front-door tests pin both. Verification: npm run agent:verify -- --profile spec-only --paths CONTRIBUTING.md,.github/pull_request_template.md,docs/test/front-door.test.mjs --session-dir task-sessions/test-docs-followup-20260820 Affected: CONTRIBUTING.md .github/pull_request_template.md docs/test/front-door.test.mjs Refs: #11 #8 Session: task-sessions/test-docs-followup-20260820
|
✅ OpenCodeReview: Review skipped: no items were selected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer follow-up to #11 / #8.
CONTRIBUTING listed
test:docswith the other public Node suites, then said those same suites run on Ubuntu CI and innpm test. Neither runsdocs/test. The PR template checklist also omittedtest:docs.This qualifies the CI sentence and adds
test:docsto the public-patch checklist. It does not addtest:docsto Ubuntu CI.Verification:
spec-onlypassed.