handle null service account on CF deploy

CHANGELOG.md

@@ -1 +1,2 @@
 - Fixed a bug where the Admin SDK would not automatically connect to the Data Connect emulator when run in the Functions emulator. (#8379)
+- Fix Cloud Functions deployment failure when service account is null. (#8381)

src/gcp/cloudfunctions.spec.ts

@@ -288,6 +288,24 @@ describe("cloudfunctions", () => {
         serviceAccountEmail: `robot@${ENDPOINT.project}.iam.gserviceaccount.com`,
       });
     });
+
+    it("should handle null service account", () => {
+      expect(
+        cloudfunctions.functionFromEndpoint(
+          {
+            ...ENDPOINT,
+            httpsTrigger: {},
+            serviceAccount: null,
+          },
+          UPLOAD_URL,
+        ),
+      ).to.deep.equal({
+        ...CLOUD_FUNCTION,
+        sourceUploadUrl: UPLOAD_URL,
+        httpsTrigger: {},
+        serviceAccountEmail: null,
+      });
+    });
   });
 
   describe("endpointFromFunction", () => {

src/gcp/cloudfunctions.ts

@@ -151,8 +151,8 @@
  * @param type Type of deployment - create, update, or delete.
  * @param err The error returned from the operation.
  */
 function functionsOpLogReject(funcName: string, type: string, err: any): void {
   if (err?.context?.response?.statusCode === 429) {
     utils.logWarning(
       `${clc.bold(
         clc.yellow("functions:"),
@@ -164,8 +164,8 @@
     );
   }
   throw new FirebaseError(`Failed to ${type} function ${funcName}`, {
     original: err,
     status: err?.context?.response?.statusCode,
     context: { function: funcName },
   });
 }
@@ -187,7 +187,7 @@
       { retryCodes: [503] },
     );
     return res.body.uploadUrl;
   } catch (err: any) {
     logger.info(
       "\n\nThere was an issue deploying your functions. Verify that your project has a Google App Engine instance setup at https://console.cloud.google.com/appengine and try again. If this issue persists, please contact support.",
     );
@@ -222,7 +222,7 @@
       type: "create",
       done: false,
     };
   } catch (err: any) {
     throw functionsOpLogReject(cloudFunction.name, "create", err);
   }
 }
@@ -248,10 +248,10 @@
       policy: options.policy,
       updateMask: Object.keys(options.policy).join(","),
     });
   } catch (err: any) {
     throw new FirebaseError(`Failed to set the IAM Policy on the function ${options.name}`, {
       original: err,
       status: err?.context?.response?.statusCode,
     });
   }
 }
@@ -681,7 +681,7 @@
   );
 
   proto.convertIfPresent(gcfFunction, endpoint, "serviceAccountEmail", "serviceAccount", (from) =>
-    proto.formatServiceAccount(from!, endpoint.project, true /* removeTypePrefix */),
+    !from ? null : proto.formatServiceAccount(from, endpoint.project, true /* removeTypePrefix */),
   );
   proto.convertIfPresent(
     gcfFunction,

src/gcp/cloudfunctionsv2.spec.ts

@@ -421,7 +421,7 @@ describe("cloudfunctionsv2", () => {
       });
     });
 
-    it("should expand shorthand SA to full email", () => {
+    it("should expand shorthand service account to full email", () => {
       expect(
         cloudfunctionsv2.functionFromEndpoint({
           ...ENDPOINT,
@@ -436,6 +436,22 @@ describe("cloudfunctionsv2", () => {
         },
       });
     });
+
+    it("should handle null service account", () => {
+      expect(
+        cloudfunctionsv2.functionFromEndpoint({
+          ...ENDPOINT,
+          serviceAccount: null,
+          httpsTrigger: {},
+        }),
+      ).to.deep.equal({
+        ...CLOUD_FUNCTION_V2,
+        serviceConfig: {
+          ...CLOUD_FUNCTION_V2.serviceConfig,
+          serviceAccountEmail: null,
+        },
+      });
+    });
   });
 
   describe("endpointFromFunction", () => {

src/gcp/cloudfunctionsv2.ts

@@ -518,7 +518,10 @@ export function functionFromEndpoint(endpoint: backend.Endpoint): InputCloudFunc
     endpoint,
     "serviceAccountEmail",
     "serviceAccount",
-    (from) => proto.formatServiceAccount(from!, endpoint.project, true /* removeTypePrefix */),
+    (from) =>
+      !from
+        ? null
+        : proto.formatServiceAccount(from, endpoint.project, true /* removeTypePrefix */),
   );
   // Memory must be set because the default value of GCF gen 2 is Megabytes and
   // we use mebibytes