Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle null service account on CF deploy #8381

Merged
merged 6 commits into from
Mar 28, 2025
Merged

handle null service account on CF deploy #8381

merged 6 commits into from
Mar 28, 2025

Conversation

leoortizz
Copy link
Member

@leoortizz leoortizz commented Mar 27, 2025 •
edited
Loading

Description

Fixes #8378.

@taeold FWICT the change that caused the error was introduced in #8366

Before:

before-error

before-logs

After:

after-log

Scenarios Tested

firebase deploy with a Next.js 15 app

Sample Commands

firebase deploy

@leoortizz leoortizz self-assigned this Mar 27, 2025
haggbart
haggbart approved these changes Mar 27, 2025
View reviewed changes
Copy link

@haggbart haggbart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Note: The changelog entry "Fix webframeworks deployments when deploying a SSR project" doesn't match this fix. Should be something like "Fix Cloud Functions deployment failure when service account is set to null"

@haggbart haggbart mentioned this pull request Mar 28, 2025
Closed
leoortizz
leoortizz commented Mar 28, 2025
View reviewed changes
@leoortizz leoortizz changed the title handle null service account handle null service account on CF deploy Mar 28, 2025
@taeold taeold enabled auto-merge (squash) March 28, 2025 18:06
@taeold taeold merged commit 976637e into master Mar 28, 2025
49 checks passed
@leoortizz leoortizz deleted the leoortizz_8378 branch March 31, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haggbart haggbart haggbart approved these changes

@taeold taeold taeold approved these changes

@MarioPreja MarioPreja MarioPreja approved these changes

@jamesdaniels jamesdaniels Awaiting requested review from jamesdaniels

Assignees

@leoortizz leoortizz

Labels
api: functions integration: web frameworks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webframeworks project deployment fails on v14
4 participants
@leoortizz @haggbart @taeold @MarioPreja