Fix GCF V2 Artifact Registry cleanup #8318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the artifact name encoding logic to match GCF V2's format when cleaning up function artifacts from Artifact Registry.
The artifact names follow this schema:
Each part is encoded separately with these rules:
<lower><dash><lower>
<underscore><lower>
Changes
ArtifactRegistryCleaner.packagePath()
to encode each part separatelyExample
Testing
Related Issues
Fixes #8164
Scenarios Tested
firebase deploy --only functions
firebase deploy --only hosting
Both cases now show the
200
http status code instead of404
when cleaning up artifacts: