-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING(functions)] Update post-deploy function logic to stop aggressively deleting conatiners #8324
Conversation
5f4897b
to
e2d426f
Compare
@chalosalvador that's a good change, but I think I'm going to suggest that Functions still move on from trying to maintain the container cleanup logic. The logic is still used in |
9a5d584
to
f6cc8ac
Compare
1f818f0
to
a589d30
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8324 +/- ##
==========================================
+ Coverage 50.94% 51.07% +0.12%
==========================================
Files 425 425
Lines 30230 30362 +132
Branches 6192 6219 +27
==========================================
+ Hits 15401 15507 +106
- Misses 13446 13467 +21
- Partials 1383 1388 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the compromise to the internal discussion that the deployment will succeed but we'll exit with non-zero if the there is no policy, no opt-out, is non-interactive, and force isn't set.
b6e57f2
to
d0145cf
Compare
Today, CLI attempts to clean up GCF artifacts (container images) in Artifact Registry post function deploys.
Historically, this post-deploy cleanup task had not been too reliable, and the resulting warning logs have confused developers.
We are trying a different approach - instead of trying to clean up the artifacts on every deploy, we'll make it easy for developers to set up a Artifact Registry Cleanup Policy on repository used by Cloud Run functions.
Cleanup policies are a managed service feature that automatically removes container images based on configurable rules, providing a more robust and transparent solution.
As suggested in this change, we'll automatically set up a clean up policy post-function deployment if we detect that a clean up policy doesn't exist yet.
We'll soon be updating the documentations to clarify what developers should do in order to avoid small monthly cost for Firebase Function's use of Artifact Registry.
Fixes #4954, #4954, #8164, #4757