Skip to content

VinF Hybrid Inference: @types/dom-chromium-ai #8920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: vertexai-hybridinference-integration
Choose a base branch
from

Conversation

hsubox76
Copy link
Contributor

Use yarn's nohoist option to prevent @types/dom-chromium-ai from being hosted to the root-level node_modules and interfering with other packages that should not include it. We may want to look into doing this for some other @types packages as well, that could be causing interference.

Copy link

changeset-bot bot commented Apr 10, 2025

⚠️ No Changeset found

Latest commit: d8f8fb3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

google-cla bot commented Apr 10, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hsubox76 hsubox76 changed the title Add @types/dom-chromium-ai VinF Hybrid Inference: @types/dom-chromium-ai Apr 10, 2025
@hsubox76 hsubox76 marked this pull request as ready for review April 10, 2025 17:57
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 10, 2025

@hsubox76 hsubox76 changed the base branch from vertexai-hybridinference-integration to main April 10, 2025 18:25
"repo-scripts/*"
],
"nohoist": [
"**/vertexai/@types/dom-chromium-ai"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Copy link

@erikeldridge erikeldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll close #8916 in favor of this change. Once this merges, I'll pull the latest main into #8874.

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v10.0

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 11, 2025

@hsubox76 hsubox76 force-pushed the ch-test-dom-chromium branch from b54f091 to b523528 Compare April 14, 2025 22:50
@hsubox76 hsubox76 changed the base branch from main to vertexai-hybridinference-integration April 14, 2025 22:51
@hsubox76 hsubox76 changed the base branch from vertexai-hybridinference-integration to main April 14, 2025 22:54
@hsubox76 hsubox76 force-pushed the ch-test-dom-chromium branch from b523528 to 8302584 Compare April 14, 2025 23:07
@hsubox76 hsubox76 changed the base branch from main to vertexai-hybridinference-integration April 14, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants