Skip to content

VinF Hybrid Inference #0: add dom-chromium-ai dep #8916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

erikeldridge
Copy link

@erikeldridge erikeldridge commented Apr 9, 2025

Problem Statement

#8874 (comment) asks why we need to add "dom" to the posttinstall script's tsconfig. The reason is because adding the @types/dom-chromium-ai to vertex causes the postinstall script to fail with errors like:

~/firebase-js-sdk $ yarn                                                                                   
...
[5/5] 🔨  Building fresh packages...
$ patch-package && yarn --cwd repo-scripts/changelog-generator build
patch-package 7.0.2
Applying patches...
[email protected] ✔
yarn run v1.22.22
$ tsc
../../node_modules/@types/dom-chromium-ai/index.d.ts:20:29 - error TS2304: Cannot find name 'AddEventListenerOptions'.

20         options?: boolean | AddEventListenerOptions,
                               ~~~~~~~~~~~~~~~~~~~~~~~

If this passes in CI, that'll be a clue for how to proceed.

Repro Steps

  1. Create branch based on integration branch
  2. Run git clean -fdx from repo root
  3. Run yarn and observe success
  4. cd into packages/vertexai
  5. Install AI types: yarn add -D @types/dom-chromium-ai
  6. cd back into repo root
  7. Run yarn and observe error
  8. Add "dom" lib to changelog script's tsconfig
  9. Run yarn from root and yarn test from vertex dir and observe success

@erikeldridge erikeldridge requested a review from a team as a code owner April 9, 2025 21:04
Copy link

changeset-bot bot commented Apr 9, 2025

⚠️ No Changeset found

Latest commit: 6ee7431

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 9, 2025

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v8.0

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@erikeldridge
Copy link
Author

#8920 adds this dep in a better way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants