VinF Hybrid Inference #0: add dom-chromium-ai dep #8916
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
#8874 (comment) asks why we need to add "dom" to the posttinstall script's tsconfig. The reason is because adding the @types/dom-chromium-ai to vertex causes the postinstall script to fail with errors like:
If this passes in CI, that'll be a clue for how to proceed.
Repro Steps
git clean -fdx
from repo rootyarn
and observe successyarn add -D @types/dom-chromium-ai
yarn
and observe erroryarn
from root andyarn test
from vertex dir and observe success