fix: publicly export GasDuration
#1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1897 +/- ##
==========================================
+ Coverage 75.54% 75.55% +0.01%
==========================================
Files 152 152
Lines 15106 15106
==========================================
+ Hits 11412 11414 +2
+ Misses 3694 3692 -2
|
LesnyRumcajs
approved these changes
Sep 27, 2023
Stebalien
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GasDurationis used in public APIGasTimer::new(duration: &mut GasDuration)and as a public fieldpub elapsed: GasDurationinGasCharge, however, it's not publicly exported from the crate. It will be helpful for e.g. converting between GasDuration in fvm@3 and fvm@4This PR tries to fix that by publicly exporting it. Please let me know your feedback, thanks!