Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly set elapsed field in type convertion logic between GasChargeV3 and GasChargeV4 #3524

Closed
hanabi1224 opened this issue Sep 27, 2023 · 3 comments · Fixed by #3520
Closed

Properly set elapsed field in type convertion logic between GasChargeV3 and GasChargeV4 #3524

hanabi1224 opened this issue Sep 27, 2023 · 3 comments · Fixed by #3520

Comments

@hanabi1224
Copy link
Contributor

Issue summary

The GasDuration field has been exported publicly in filecoin-project/ref-fvm#1897
We need to take a new fvm release to implement it (otherwise we might have to use some hacky unsafe code to manipulate the private type)

Other information and links
@lemmih
Copy link
Contributor

lemmih commented Sep 27, 2023

We don't care about elapsed. We can ignore it or set it to zero.

@hanabi1224 hanabi1224 linked a pull request Sep 27, 2023 that will close this issue
fvm4 shim types #3520
Merged
4 tasks
@hanabi1224 hanabi1224 mentioned this issue Sep 27, 2023
Merged
4 tasks
@Stebalien
Copy link
Collaborator

Released.

@LesnyRumcajs
Copy link
Member

Thank you @Stebalien !

@elmattic elmattic mentioned this issue Nov 29, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fvm4 shim types ChainSafe/forest
4 participants
@Stebalien @lemmih @hanabi1224 @LesnyRumcajs