Open
Conversation
This was referenced Jan 20, 2026
To prepare for fgsfdsfgs#627, this commit added Accept/Cancel Swap for Menu Navigation. This function only applies when using a Nintendo Switch controller, but it can be forcefully enabled for all Controller Types within `pd.ini`'s `swapAcceptCancelButtons`
416bc85 to
9edcda5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note: this PR requires #627
What
SDL_HINT_GAMECONTROLLER_USE_BUTTON_LABELSdoes is that SDL's Controller API will follow on Button Labels, by default: it is set to1. Consequences: the modern Nintendo Switch layout will be using the Nintendo Layout across Menu Navigation and Gameplay.Beyond copy-pasting: it results in muscle memory. The initial workaround would be to rebind to the Key Binding section, but I argue it ain't very nice.
Taking a page from yquake2/yquake2@9e07dc2, I took a stab at it myself. the result was originally hacky, but it has been cleaned up to make it easier to prepare for SDL3 Migration down in the line. Do note that it only applies to both "ACCEPT_BUTTON/CK_ACCEPT" and "CANCEL_BUTTON/CK_CANCEL" action,.
While both toggles aren't accessible in-game, both
swapAcceptCancelButtons(will only swap Menu Accept/Cancel) is always accessible withinpd.ini.