Uses Positional Face Button Layout instead of Button Labels

[AL2009man]

this SDL Hint will disable SDL_HINT_GAMECONTROLLER_USE_BUTTON_LABELS. allowing all Controllers to use the positional layout (SDL3-style) as opposed to Button Labels. refer to #693 for more info

This addresses a specific problem with Nintendo Switch controllers where the Face Buttons are assigned in a literal Button Symbol position, causes muscle memory issues while maintaining consistency across all modern controllers.

for those who...somehow, prefer the prior setup: you can restore it by either rebinding it from Key Binding (per controller) or set useNintendoLayout to 1 (global, affects all Controllers).

[fgsfdsfgs]

I'd argue useNintendoLayout should be set to 1 by default, to not confuse people that already had a config from before this change.

[AL2009man]

I'd argue useNintendoLayout should be set to 1 by default, to not confuse people that already had a config from before this change.

You sure? This will become a problem when you guys start migrating to SDL3, which will deprecate SDL_HINT_GAMECONTROLLER_USE_BUTTON_LABELS in the process.

You'll have to create a entirely new Face Button swap detection mechanism if you really wanna ensure Nintendo Switch controller users maintain the same config setup as before.

edit: I can plan on making the NintendoLayout as the default and change #625 to follow useNintendoLayout, but this ultimately depends on @fgsfdsfgs' wishes.

[fgsfdsfgs]

Well, my point is, if I take this PR by itself and merge it, by default it should work like it did before this PR, because updating and suddenly getting your accept/cancel buttons swapped is probably a bit jarring. And from your comments in the code it seems like useNintendoLayout=1 would correspond to that state? Or did I misread "this is default hint in SDL 2.0.6 and later" as the opposite of what it actually is?

[AL2009man]

The way how I have written the notes is based upon SDL_Hints documents. Those who might be reading the code may not be familiar to those who haven't dabbled with SDL before. I'll go ahead and update the name and description to better clarity. (won't be pushed over to this PR until i get a response)

that means:

usePositionalFaceButtonLayout=0 - uses Button Labels function
usePositionalFaceButtonLayout=1 - uses Positional Face Button Layout

if usePositionalFaceButtonLayout is set to 0: the Face Button layout will be following the Button Labels (A/B/X/Y) of your controller. Prior to this PR: this is the default as per SDL SetHint, If using a Nintendo GameCube Controller, N64 Controller or heck, any NSO Nintendo Controllers: the layout of the physical face buttons will be more direct about it. Basically: this is the same function as before, but again: it only applies to Controllers that doesn't follow the Xbox/PlayStation layout...if you were to switch between a Xbox to Nintendo Switch controller for testings: you'd get a muscle memory issue.

if said toggle is set to 1: that specific SDL hint will instead be based on the Face Button's diamond-shape positions (SOUTH/EAST/WEST/NORTH) instead, and this will become the defacto default starting in SDL 3.2.0 while removing SDL_HINT_GAMECONTROLLER_USE_BUTTON_LABELS entirely, the SDL maintainers will instead recommend you to create a "UI Accept and Cancel" system instead (refer to libsdl-org/SDL#6117, there's a reason why SDL maintainers ditched the Face Button Labels)

as for Accept/Cancel stuffs (#693): don't worry, I already have a plan. If you want usePositionalFaceButtonLayout=0: I'll need to go ahead and disabled the entire function when usePositionalFaceButtonLayout=0 is in use.

ultimately, @fgsfdsfgs: you got three choices, all three choice will ultimately lead you to a "illusion of choice":

• set usePositionalFaceButtonLayout=0 as the default, retaining the Face Button label order from before
  • however: when the SDL3 migration begins: said toggle will have to be removed entirely, or implement a new Face Button-specific functionality to maintain backwards compatibility.
• set usePositionalFaceButtonLayout=1 as the default, no need to deal with the headache during SDL3 migration.
• set usePositionalFaceButtonLayout=0 as the default, but UI Accept/Cancel Swap support #693 will enable the toggle by default going forward, this better accounts for backwards compatibility

[fgsfdsfgs]

One thing that's for sure is that we'll worry about the SDL3 migration when we get there. I'm still waiting on the Switch port to stabilize, so it'll probably take a while.

If this only applies to some controllers, then we can probably merge this as-is.

[AL2009man]

If this only applies to some controllers, then we can probably merge this as-is.

that's correct. if usePositionalFaceButtonLayout is set to 0: some controllers like the Nintendo Switch controllers' face buttons will be following the labels. If set to 1: it'll follow the Xbox-style layout regardless of what controller you're using, refer to this image if you'd like to have a better idea.