Skip to content

Use dynamic port for Playwright test server #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neuralsorcerer wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Use dynamic port for Playwright test server #16

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0da6747
Use dynamic port for Playwright test server
neuralsorcerer Dec 6, 2025
4febca9
Merge branch 'main' into port
neuralsorcerer Dec 8, 2025
8615ba3
Merge branch 'main' into port
neuralsorcerer Dec 8, 2025
eda4aa3
Fix lint
neuralsorcerer Dec 8, 2025
6e58624
Merge branch 'main' into port
neuralsorcerer Dec 8, 2025
5d0bf65
Merge branch 'main' into port
neuralsorcerer Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/prompt_siren/environments/playwright.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,17 @@ async def _init_server(self) -> None:
app.router.add_post("/{tail:.*}", handle_post)
runner = AppRunner(app)
await runner.setup()
# TODO: make sure port is not used
site = TCPSite(runner, "localhost", 42352)
site = TCPSite(runner, "localhost", 0)
await site.start()
self._server = Server(runner, site, site._port)

server = site._server
sockets = getattr(server, "sockets", None) if server is not None else None
if not sockets:
await runner.cleanup()
raise RuntimeError("Failed to bind Playwright server socket")

port = sockets[0].getsockname()[1]
self._server = Server(runner, site, port)

@asynccontextmanager
async def create_batch_context(
Expand Down