Use dynamic port for Playwright test server #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
There was a problem hiding this comment.
Pull request overview
This pull request updates the Playwright environment server initialization to use dynamic port allocation instead of a hardcoded port, eliminating potential port collision issues. The changes introduce proper error handling and cleanup when socket binding fails.
Key changes:
- Replaced hardcoded port 42352 with ephemeral port allocation (port 0)
- Added socket validation and cleanup on binding failure
- Removed the TODO comment about port collision handling
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the Playwright environment server setup to bind to an ephemeral localhost port and fail fast with cleanup if the socket cannot be created, avoiding collisions with in-use ports.