move default React Native DevTools launching params downstream #54528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
vzaidman
force-pushed
the
export-D86772692
branch
from
825739f to
121fded
Compare
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Nov 14, 2025
…ook#54528) Summary: Changelog: [Internal] Currently, `DefaultBrowserLauncher.js` holds arguments configuring how the debugger shell is launched. Instead, move some of them downstream, and make `DefaultBrowserLauncher.js` use the defaults. Differential Revision: D86772692
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Nov 17, 2025
…ook#54528) Summary: Changelog: [Internal] Currently, `DefaultBrowserLauncher.js` holds arguments configuring how the debugger shell is launched. Instead, move some of them downstream, and make `DefaultBrowserLauncher.js` use the defaults. Differential Revision: D86772692
vzaidman
force-pushed
the
export-D86772692
branch
2 times, most recently
from
db616e4 to
692553c
Compare
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Nov 18, 2025
…ook#54528) Summary: Changelog: [Internal] Currently, `DefaultBrowserLauncher.js` holds arguments configuring how the debugger shell is launched. Instead, move some of them downstream, and make `DefaultBrowserLauncher.js` use the defaults. Differential Revision: D86772692
vzaidman
force-pushed
the
export-D86772692
branch
from
692553c to
e6ff429
Compare
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Nov 19, 2025
…ook#54528) Summary: Changelog: [Internal] Currently, `DefaultBrowserLauncher.js` holds arguments configuring how the debugger shell is launched. Instead, move some of them downstream, and make `DefaultBrowserLauncher.js` use the defaults. Differential Revision: D86772692
…g event on if this changes (facebook#54447) Summary: Changelog: [Internal] Expose `unstable_hasConnectedDevices` and `unstable_addHasConnectedDevicesListener` from both `InspectorProxy` and `DevMiddleware` that tells the user if any devices are connected to `devMiddleware` and allows to listen to whenever this state changes. Reviewed By: motiz88 Differential Revision: D86319965
Summary: make the default debugger-shell spawn command unset ELECTRON_RUN_AS_NODE Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D86673603
…ook#54528) Summary: Changelog: [Internal] Currently, `DefaultBrowserLauncher.js` holds arguments configuring how the debugger shell is launched. Instead, move some of them downstream, and make `DefaultBrowserLauncher.js` use the defaults. Differential Revision: D86772692
vzaidman
force-pushed
the
export-D86772692
branch
from
e6ff429 to
ed7c9b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Currently,
DefaultBrowserLauncher.jsholds arguments configuring how the debugger shell is launched. Instead, move some of them downstream, and makeDefaultBrowserLauncher.jsuse the defaults.Differential Revision: D86772692