move default React Native DevTools launching params downstream (facebook#54528)

Summary:

Changelog: [Internal]

Currently, `DefaultBrowserLauncher.js` holds arguments configuring how the debugger shell is launched. Instead, move some of them downstream, and make `DefaultBrowserLauncher.js` use the defaults.

Differential Revision: D86772692

Author: vzaidman

packages/debugger-shell/src/node/index.flow.js

@@ -29,7 +29,7 @@ async function unstable_spawnDebuggerShellWithArgs(
   args: string[],
   {
     mode = 'detached',
-    flavor = 'prebuilt',
+    flavor = process.env.RNDT_DEV === '1' ? 'dev' : 'prebuilt',
     prebuiltBinaryPath,
   }: $ReadOnly<{
     // In 'syncAndExit' mode, the current process will block until the spawned process exits, and then it will exit
@@ -38,7 +38,7 @@ async function unstable_spawnDebuggerShellWithArgs(
     // continue to run normally.
     mode?: 'syncThenExit' | 'detached',
     flavor?: DebuggerShellFlavor,
-    prebuiltBinaryPath?: string,
+    prebuiltBinaryPath?: ?string,
   }> = {},
 ): Promise<void> {
   const [binaryPath, baseArgs] = getShellBinaryAndArgs(
@@ -119,10 +119,13 @@ export type DebuggerShellPreparationResult = $ReadOnly<{
  * instantly when the user tries to open it (and conversely, the user is
  * informed ASAP if it is not ready to use).
  */
-async function unstable_prepareDebuggerShell(
-  flavor: DebuggerShellFlavor,
-  {prebuiltBinaryPath}: {prebuiltBinaryPath?: string} = {},
-): Promise<DebuggerShellPreparationResult> {
+async function unstable_prepareDebuggerShell({
+  prebuiltBinaryPath,
+  flavor = process.env.RNDT_DEV === '1' ? 'dev' : 'prebuilt',
+}: {
+  prebuiltBinaryPath?: ?string,
+  flavor?: DebuggerShellFlavor,
+} = {}): Promise<DebuggerShellPreparationResult> {
   try {
     switch (flavor) {
       case 'prebuilt':

packages/dev-middleware/src/utils/DefaultBrowserLauncher.js

@@ -73,19 +73,16 @@ const DefaultBrowserLauncher = {
     url: string,
     windowKey: string,
   ): Promise<void> {
-    return await unstable_spawnDebuggerShellWithArgs(
-      ['--frontendUrl=' + url, '--windowKey=' + windowKey],
-      {
-        mode: 'detached',
-        flavor: process.env.RNDT_DEV === '1' ? 'dev' : 'prebuilt',
-      },
-    );
+    return await unstable_spawnDebuggerShellWithArgs([
+      '--frontendUrl=' + url,
+      '--windowKey=' + windowKey,
+    ]);
   },
 
-  async unstable_prepareFuseboxShell(): Promise<DebuggerShellPreparationResult> {
-    return await unstable_prepareDebuggerShell(
-      process.env.RNDT_DEV === '1' ? 'dev' : 'prebuilt',
-    );
+  async unstable_prepareFuseboxShell(
+    prebuiltBinaryPath?: ?string,
+  ): Promise<DebuggerShellPreparationResult> {
+    return await unstable_prepareDebuggerShell();
   },
 };