Skip to content

janga:config: Update hotswap power sensor multiplication factor #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+24 −4
Closed

janga:config: Update hotswap power sensor multiplication factor #601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9382b4a
janga:config: Update hotswap power sensor multiplication factor
lucas-alencar Oct 16, 2025
120df03
update the adm1272 PMON_CONTROL command
lucas-alencar Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fboss/platform/configs/janga800bic/platform_manager.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2067,7 +2067,7 @@
"chassisEepromDevicePath": "/SMB_FRU_SLOT@0/[IDPROM]",
"numXcvrs": 46,
"bspKmodsRpmName": "fboss_bsp_kmods",
"bspKmodsRpmVersion": "3.3.2-1",
"bspKmodsRpmVersion": "3.4.0-1",
"requiredKmodsToLoad": [
"i2c_i801",
"spidev",
Expand Down
26 changes: 23 additions & 3 deletions fboss/platform/configs/janga800bic/sensor_service.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,11 +162,22 @@
"maxAlarmVal": 63,
"upperCriticalVal": 65
},
"__comment__": "Update the multiplier to 3 because the HW design has 3 milliohm resistors in parallel, giving an equivalent resistance of 0.333 milliohms",
Copy link
Contributor

@somasun somasun Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment

"compute": "3*@/1000.0"
},
{
"name": "SMB_U279_MAIN_HSC_ADM1272_VIN",
"sysfsPath": "/run/devmap/sensors/SMB_U279_ADM1272_1/in1_input",
"type": 1,
"thresholds": {
"maxAlarmVal": 58,
"upperCriticalVal": 60
},
"compute": "@/1000.0"
},
{
"name": "SMB_U279_MAIN_HSC_ADM1272_VOUT",
"sysfsPath": "/run/devmap/sensors/SMB_U279_ADM1272_1/in1_input",
"sysfsPath": "/run/devmap/sensors/SMB_U279_ADM1272_1/in2_input",
"type": 1,
"thresholds": {
"maxAlarmVal": 58,
Expand All @@ -175,14 +186,15 @@
"compute": "@/1000.0"
},
{
"name": "SMB_U279_MAIN_HSC_ADM1272_POUT",
"name": "SMB_U279_MAIN_HSC_ADM1272_PIN",
"sysfsPath": "/run/devmap/sensors/SMB_U279_ADM1272_1/power1_input",
"type": 0,
"thresholds": {
"maxAlarmVal": 2800,
Copy link
Contributor

@somasun somasun Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this sensor be called SMB_U279_MAIN_HSC_ADM1272_PIN, since it is tracking power1_input. Ditto, for VOUT, IOUT references for this HSC.

Copy link
Contributor

@somasun somasun Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know if there is a different reasoning to POUT

Copy link
Contributor Author

@clslucas clslucas Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@somasun Update naming conventions according to the adm1272 datasheet with new commit, please help to check it. thanks.
image
image

"upperCriticalVal": 3000
},
"compute": "@/1000000.0"
"__comment__": "Update the multiplier to 3 because the HW design has 3 milliohm resistors in parallel, giving an equivalent resistance of 0.333 milliohms",
Copy link
Contributor

@somasun somasun Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment

"compute": "3*@/1000000.0"
},
{
"name": "SMB_U279_MAIN_HSC_ADM1272_TEMP",
Expand Down Expand Up @@ -9897,5 +9909,13 @@
}
]
}
],
"powerConsumptionConfigs": [
{
"__comment__": "Hot-swap VRM chip ADM1272 monitors the power consumption of the entire system",
"name": "HSC",
"voltageSensorName": "SMB_U279_MAIN_HSC_ADM1272_VOUT",
"currentSensorName": "SMB_U279_MAIN_HSC_ADM1272_IOUT"
}
]
}
Loading