janga:config: Update hotswap power sensor multiplication factor #601
+24
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somasun
reviewed
Oct 16, 2025
| "upperCriticalVal": 3000 | ||
| }, | ||
| "compute": "@/1000000.0" | ||
| "__comment__": "Update the multiplier to 3 because the HW design has 3 milliohm resistors in parallel, giving an equivalent resistance of 0.333 milliohms", |
| "upperCriticalVal": 65 | ||
| }, | ||
| "compute": "@/1000.0" | ||
| "__comment__": "Update the multiplier to 3 because the HW design has 3 milliohm resistors in parallel, giving an equivalent resistance of 0.333 milliohms", |
| "sysfsPath": "/run/devmap/sensors/SMB_U279_ADM1272_1/power1_input", | ||
| "type": 0, | ||
| "thresholds": { | ||
| "maxAlarmVal": 2800, |
There was a problem hiding this comment.
Should this sensor be called SMB_U279_MAIN_HSC_ADM1272_PIN, since it is tracking power1_input. Ditto, for VOUT, IOUT references for this HSC.
There was a problem hiding this comment.
Please let me know if there is a different reasoning to POUT
There was a problem hiding this comment.
@somasun Update naming conventions according to the adm1272 datasheet with new commit, please help to check it. thanks.
somasun
requested changes
Oct 17, 2025
|
@clslucas has updated the pull request. You must reimport the pull request before landing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the multiplication factors Iout and Pout for the hot swap chip ADM1272.
Motivation
Test Plan
Run sensor_service with the new config file: LD_LIBRARY_PATH=./fboss_lib/ ./sensor_service --config_file sensor_service.json
Currently testing the new configuration file is normal.
Janga-platform_manager_log_20251016.txt
janga_sensor_log_20251016.txt
Update the sensor test log:
janga_sensor_log_20251020.txt