Skip to content

Icetea: config: bump bsp version to v3.4.0-1 and update sensors calibration for tps25990 and ltc4287 #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+6 −6
Closed

Icetea: config: bump bsp version to v3.4.0-1 and update sensors calibration for tps25990 and ltc4287 #591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b68aee7
Icetea: config: bump bsp version to v3.4.0-1 and update sensors calib…
joywu-coder Oct 14, 2025
ebd73b1
Merge branch 'facebook:main' into icetea_bump_bsp_version_3.4.0
joywu-coder Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fboss/platform/configs/icetea/platform_manager.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1667,7 +1667,7 @@
"chassisEepromDevicePath": "/[CHASSIS_IDPROM]",
"numXcvrs": 33,
"bspKmodsRpmName": "fboss_bsp_kmods",
"bspKmodsRpmVersion": "3.3.2-1",
"bspKmodsRpmVersion": "3.4.0-1",
"requiredKmodsToLoad": [
"i2c_i801",
"spidev",
Expand Down
10 changes: 5 additions & 5 deletions fboss/platform/configs/icetea/sensor_service.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@
"maxAlarmVal": 10,
"upperCriticalVal": 11
},
"compute": "@/1000"
"compute": "0.274*@/1000"
Copy link
Contributor

@binhuang00 binhuang00 Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joywu-coder, as you updated the compute formula, should the "maxAlarmVal" and "upperCriticalVal" be updated too?

Copy link
Contributor Author

@joywu-coder joywu-coder Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joywu-coder, as you updated the compute formula, should the "maxAlarmVal" and "upperCriticalVal" be updated too?

@binhuang00 Thanks for your comments. The original threshold(maxAlarmVal/upperCriticalVal) setting is expected; we only need to correct the formula factor.

},
{
"name": "MCB_PU925_TPS25990_XP12R0V_COME_PIN",
Expand All @@ -154,7 +154,7 @@
"maxAlarmVal": 120,
"upperCriticalVal": 130
},
"compute": "@/1000000"
"compute": "0.274*@/1000000"
Copy link
Contributor

@binhuang00 binhuang00 Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto, "maxAlarmVal" and "upperCriticalVal" should be updated too?

Copy link
Contributor Author

@joywu-coder joywu-coder Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto, "maxAlarmVal" and "upperCriticalVal" should be updated too?

Same as above

},
{
"name": "MCB_PU925_TPS25990_XP12R0V_COME_TEMP",
Expand All @@ -176,7 +176,7 @@
},
{
"name": "MCB_PU925_TPS25990_XP12R0V_COME_VOUT",
"sysfsPath": "/run/devmap/sensors/MCB_LOAD_SWITCH_MONITOR/in2_input",
"sysfsPath": "/run/devmap/sensors/MCB_LOAD_SWITCH_MONITOR/in3_input",
"type": 1,
"thresholds": {
"maxAlarmVal": 13.2,
Expand Down Expand Up @@ -1253,13 +1253,13 @@
"name": "FCB_XP48R0V_HOTSWAP_IOUT",
"sysfsPath": "/run/devmap/sensors/FCB_48V_HSC_MONITOR/curr1_input",
"type": 2,
"compute": "2.4*@/1000"
"compute": "1.8*@/1000"
},
{
"name": "FCB_XP48R0V_HOTSWAP_PIN",
"sysfsPath": "/run/devmap/sensors/FCB_48V_HSC_MONITOR/power1_input",
"type": 0,
"compute": "2.4*@/1000000"
"compute": "1.8*@/1000000"
},
{
"name": "FCB_XP48R0V_HOTSWAP_TEMP",
Expand Down
Loading