Skip to content

Conversation

@joywu-coder
Copy link
Contributor

Description

  1. Bump the BSP version to 3.4.0-1 in the platform config.
  2. Change the sensor sysfs path of MCB_PU925_TPS25990_XP12R0V_COME_VOUT from in2_input to in3_input due to bsp tps25990 driver updated.
  3. Update the sensors' calibration of MCB_PU925_TPS25990_XP12R0V_COME_IIN and MCB_PU925_TPS25990_XP12R0V_COME_PIN to 0.274.
  4. Update the sensors' calibration of FCB_XP48R0V_HOTSWAP_IOUT and FCB_XP48R0V_HOTSWAP_PIN to 1.8.

Motivation

  1. According to the latest BSP tag, bump the BSP version to 3.4.0-1 in the platform config.
  2. To align with the HW requirement, we need to adjust the sensors' calibration value in the sensor config.

Test Plan

  1. The format has been verified as correct on the JSONLint website.
  2. Used the jq command to pretty-print the format.
  3. Test log as follows:
image

platform_manager_log.txt
platform_manager_hw_test_log.txt
sensor_service_log.txt
sensor_service_hw_test_log.txt
fan_service_log.txt
fan_service_hw_test_log.txt

@meta-cla meta-cla bot added the CLA Signed label Oct 14, 2025
"upperCriticalVal": 11
},
"compute": "@/1000"
"compute": "0.274*@/1000"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joywu-coder, as you updated the compute formula, should the "maxAlarmVal" and "upperCriticalVal" be updated too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joywu-coder, as you updated the compute formula, should the "maxAlarmVal" and "upperCriticalVal" be updated too?

@binhuang00 Thanks for your comments. The original threshold(maxAlarmVal/upperCriticalVal) setting is expected; we only need to correct the formula factor.

"upperCriticalVal": 130
},
"compute": "@/1000000"
"compute": "0.274*@/1000000"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto, "maxAlarmVal" and "upperCriticalVal" should be updated too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto, "maxAlarmVal" and "upperCriticalVal" should be updated too?

Same as above

@meta-codesync
Copy link

meta-codesync bot commented Oct 22, 2025

@binhuang00 has imported this pull request. If you are a Meta employee, you can view this in D85219459.

@meta-codesync
Copy link

meta-codesync bot commented Oct 24, 2025

@binhuang00 merged this pull request in dc359f9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants