Add a GH workflow to update crates versions weekly #40
Conversation
| @@ -7,3 +7,234 @@ edition = "2021" | |||
| path = "dummy.rs" | |||
|
|
|||
| [dependencies] | |||
| unicode-segmentation = "1.8.0" | |||
There was a problem hiding this comment.
It's great to have the dependencies listed here explicitly 👍
| echo "${{env.cargo_toml}}" > local-registry/Cargo.toml | ||
| - name: Create Pull Request | ||
| id: cpr | ||
| uses: peter-evans/create-pull-request@v3 |
There was a problem hiding this comment.
Same comment as above. @exercism/github-actions what do you think about this action?
Note that you can also use the GitHub CLI, which comes pre-installed.
There was a problem hiding this comment.
Oh, all right, I didn't know that the cli tools came pre-installed, I can create a PR this way if it's preferable.
There was a problem hiding this comment.
I think it might be slightly less susceptible to misuse (or errors)
There was a problem hiding this comment.
Wondering if that would actually work since I'm specifying container to be rust:latest...
There was a problem hiding this comment.
It won't. That said, it might be worth changing this workflow to be like https://github.com/exercism/rust/blob/main/.github/workflows/tests.yml#L113, which is the tests workflow for the rust repo. In it, the base image is ubuntu, but the action-rs action is used to install rust.
But let's wait for @exercism/github-actions to see what they think.
There was a problem hiding this comment.
Hello, it's been a few months and I'd like to know why you stopped reviewing, it was nice contributing to exercism :)
There was a problem hiding this comment.
I'm really not the right person to review this, but at a guess, the people who'd been working with you on this PR got distracted and then just forgot.
There was a problem hiding this comment.
I'm so sorry @dhovart! I guess @SaschaMann and I just forgot to review this. Our apologies.
There was a problem hiding this comment.
Ah, no worries at all :)
dhovart
force-pushed
the
update-versions-workflow
branch
from
ed0fb8e to
9402e68
Compare
|
We should maybe add as an ultimate step "cargo build" from within While working on #42 I saw that the docker build was failing because of some crates not correctly compiling. |
| default: true | ||
| - name: Retrieve newest versions of dependencies | ||
| run: ./bin/update-crates-versions.sh | ||
| - name: Create pull request |
There was a problem hiding this comment.
I would maybe split this one step into several steps, like https://github.com/exercism/org-wide-files/blob/main/.github/workflows/sync-rest.yml#L303 That makes it easier to debug what went wrong when a build fails.
| git config --global user.email "[email protected]" | ||
| git config --global user.name "Exercism Bot" |
There was a problem hiding this comment.
@SaschaMann will this work with the GITHUB_TOKEN passed in not being the token of the Exercism bot? And does it even need to be the Exercism Bot user here?
There was a problem hiding this comment.
It might show up as unverified but generally the git name and email can be whatever. For consistency, you might want to set these to match Exercism Bot elsewhere, or at least point it either at an obvious dummy email address or one that actually works, not one that looks like it may work but likely doesn't.
There was a problem hiding this comment.
I know nothing about the Rust ecosystem but cargo is supported by Dependabot. Is there any reason to not use that instead?
| git config --global user.email "[email protected]" | ||
| git config --global user.name "Exercism Bot" |
There was a problem hiding this comment.
It might show up as unverified but generally the git name and email can be whatever. For consistency, you might want to set these to match Exercism Bot elsewhere, or at least point it either at an obvious dummy email address or one that actually works, not one that looks like it may work but likely doesn't.
Ha, you're absolutely right @SaschaMann, for some reason I had not considered Dependabot, I didn't know it supported Rust projects. I suppose it's just a matter of configuring it correctly. What would be for you the right way to proceed ? Should I force-push the same branch with only these changes ? Open a new PR ? |
|
I'd say it's best to open a new PR with the dependabot config |
|
That sounds like a great option! |
|
Sorry, I might need a week or two before being able to work on this. |
|
This was superceded by #77, which added a dependabot config to the existing work to update the crates as suggested in this discussion. |
As discussed in #37
The supported crates are listed in
local-registry/Cargo.tomlunder[dependencies].I have updated the Dockerfile accordingly to remove unnecessary steps.