Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update dependencies for xorcism exercise #1540

Closed
wants to merge 1 commit into from

Conversation

vadim2404
Copy link

The platform can't build the solution with rstest_reuse==0.3.0

Decided to update all libraries to actual versions

@vadim2404
Copy link
Author

#1513 possibly, this update will help with this issue

@petertseng
Copy link
Member

I opened this exercise in the web editor, used my xorcism implmentatin, and edited Cargo.toml to have these dependencies. the result was

WARNING: student did not upload Cargo.lock. This may cause build errors.
error: failed to select a version for the requirement `hexlit = "^0.5.5"`
candidate versions found which didn't match: 0.5.3
location searched: `/opt/test-runner/local-registry` index (which is replacing registry `crates-io`)
required by package `xorcism v0.1.0 (/mnt/exercism-iteration)`
perhaps a crate was updated and forgotten to be re-vendored?
As a reminder, you're using offline mode (--offline) which can sometimes cause surprising resolution failures, if this error is too confusing you may wish to retry without the offline flag.

I think until that is solved we shouldn't do this.

I don't see any specific versions mentioned in https://github.com/exercism/rust-test-runner/blob/main/local-registry/supported_crates so I think that's just whatever was available at the time. There was a PR to automatically update crate versions in the registry in exercism/rust-test-runner#40, but a new approach to that one was desired and to my knowledge the new approach has not been started

@vadim2404
Copy link
Author

Does it mean that we need to rebuild and republish the container with the local registry?

@senekor
Copy link
Contributor

senekor commented Jul 5, 2023

The rstest dependencies were removed in favor of a simpler declarative macro. I think rstest caused the tests to timeout, because compilation took too long. My solution for this exercise from November passed the test runner.

@vadim2404 do you think we can close this?

@senekor senekor closed this Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants