-
Notifications
You must be signed in to change notification settings - Fork 27
Deprecate old tests #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gppezzi
wants to merge
8
commits into
eth-cscs:main
Choose a base branch
from
gppezzi:ReviewQ3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Deprecate old tests #403
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8f6065c
Deprecate libsci_acc_symlink.py
gppezzi d08ce12
Deprecate libsci_resolve.py
gppezzi fffb054
Deprecate hdf5.py
gppezzi 06d4a9f
Deprecate cuda_nvml.py
gppezzi a480cd7
Deprecate environ_check.py
gppezzi 52c6797
Merge branch 'main' into ReviewQ3
gppezzi 32690f2
Update checks/compile/libsci_acc_symlink.py
gppezzi bdf14a0
Update copyright and uenv part in hdf5.py
jgphpc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -50,7 +50,7 @@ def set_sanity(self): | |||||
class UENV_NVML(CudaNvmlBase): | ||||||
valid_systems = ['+nvgpu'] | ||||||
valid_prog_environs = ['+uenv +prgenv +cuda -cpe'] | ||||||
tags = {'production', 'external-resources', 'health', 'uenv'} | ||||||
tags = {'external-resources', 'health', 'uenv'} | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
@run_after('setup') | ||||||
def setup_src(self): | ||||||
|
@@ -70,7 +70,7 @@ def setup_src(self): | |||||
class CPE_NVML(CudaNvmlBase, ContainerEngineCPEMixin): | ||||||
valid_systems = ['+nvgpu'] | ||||||
valid_prog_environs = ['+cuda +cpe -uenv -containerized_cpe'] | ||||||
tags = {'production', 'external-resources', 'health', 'craype'} | ||||||
tags = {'external-resources', 'health', 'craype'} | ||||||
|
||||||
@run_after('init') | ||||||
def skip_uenv_tests(self): | ||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'production' tag should be removed from this test class as well to be consistent with the PR's purpose of deprecating stale tests by removing the 'production' tag.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no