Deprecate old tests #403
Deprecate old tests #403
Conversation
gppezzi
commented
Sep 23, 2025
gppezzi
commented
- Deprecate stale tests (removing 'production' tag) as discussed here - VCUE-1061
Co-authored-by: Jean-guillaume Piccinali <[email protected]>
Putting back prod. tag for the uenv check
| valid_systems = ['+nvgpu'] | ||
| valid_prog_environs = ['+uenv +prgenv +cuda -cpe'] | ||
| tags = {'production', 'external-resources', 'health', 'uenv'} | ||
| tags = {'external-resources', 'health', 'uenv'} |
There was a problem hiding this comment.
| tags = {'external-resources', 'health', 'uenv'} | |
| tags = {'production', 'external-resources', 'health', 'uenv'} |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the 'production' tag from various regression tests across different test categories to deprecate stale tests as part of a test review initiative.
- Removes 'production' tag from programming environment, CUDA, HDF5, and compilation tests
- Updates maintainer information in libsci_resolve.py from individual names to 'VCUE'
- Modifies test environment configuration for HDF5 tests to better handle uenv vs cpe environments
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| checks/prgenv/environ_check.py | Removes 'production' tag from three environment check test classes |
| checks/prgenv/cuda/cuda_nvml.py | Removes 'production' tag from CUDA NVML test classes |
| checks/libraries/io/hdf5.py | Removes 'production' tag from CPE HDF5 test and updates environment handling |
| checks/compile/libsci_resolve.py | Removes 'production' tag and updates maintainer to 'VCUE' |
| checks/compile/libsci_acc_symlink.py | Removes 'production' tag from LibSci acceleration symlink test |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| valid_prog_environs = ['+mpi +hdf5 +uenv'] | ||
| valid_prog_environs = ['-cpe +uenv +prgenv'] | ||
| valid_systems = ['+remote'] | ||
| tags = {'production', 'health', 'uenv'} |
There was a problem hiding this comment.
The 'production' tag should be removed from this test class as well to be consistent with the PR's purpose of deprecating stale tests by removing the 'production' tag.
| tags = {'production', 'health', 'uenv'} | |
| tags = {'health', 'uenv'} |
Copilot uses AI. Check for mistakes.
|
remove |
