Column Migration: process migrations in batches #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdibaiee
force-pushed
the
mahdi/column-migration-number
branch
from
e4cae93 to
94d70d4
Compare
mdibaiee
force-pushed
the
mahdi/column-migration-number
branch
from
3b68adc to
0c7192f
Compare
mdibaiee
force-pushed
the
mahdi/column-migration-number
branch
from
0c7192f to
6e27793
Compare
|
@williamhbaker added a commit for supporting migration from integer to number as well to this same PR |
williamhbaker
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
LGTM for the number migrations.
It would be nice to cover materialize-azure-fabric-warehouse for the number migration case as well. It does migrations a little differently since it doesn't support dropping columns, but it might be fairly trivial to add these cases to it if they can use the default CAST syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I have been unable to run tests on all connectors, I think the credentials / env for motherduck and redshift seem to have changed and I don't have credentials for cratedb
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is