materialize-sql: s/variadic/slice in column migration instructions

Author: mdibaiee

materialize-bigquery/client.go

@@ -130,7 +130,7 @@ var columnMigrationSteps = []sql.ColumnMigrationStep{
 	sql.StdMigrationSteps[1],
 	sql.StdMigrationSteps[2],
 	sql.StdMigrationSteps[3],
-	func(dialect sql.Dialect, table sql.Table, instructions ...sql.MigrationInstruction) ([]string, error) {
+	func(dialect sql.Dialect, table sql.Table, instructions []sql.MigrationInstruction) ([]string, error) {
 		// BigQuery does not support making a column REQUIRED when it is NULLABLE
 		// TODO: do we prefer to backfill in these instances for BigQuery, or just continue
 		// with this no-op as-is?

materialize-mysql/client.go

@@ -106,7 +106,7 @@ var migrationSteps = []sql.ColumnMigrationStep{
 	sql.StdMigrationSteps[0],
 	sql.StdMigrationSteps[1],
 	sql.StdMigrationSteps[2],
-	func(dialect sql.Dialect, table sql.Table, instructions ...sql.MigrationInstruction) ([]string, error) {
+	func(dialect sql.Dialect, table sql.Table, instructions []sql.MigrationInstruction) ([]string, error) {
 		var queries []string
 		for _, ins := range instructions {
 			queries = append(
@@ -123,7 +123,7 @@ var migrationSteps = []sql.ColumnMigrationStep{
 
 		return queries, nil
 	},
-	func(dialect sql.Dialect, table sql.Table, instructions ...sql.MigrationInstruction) ([]string, error) {
+	func(dialect sql.Dialect, table sql.Table, instructions []sql.MigrationInstruction) ([]string, error) {
 		var queries []string
 
 		for _, ins := range instructions {

materialize-sql/std_sql.go

@@ -456,10 +456,10 @@ type MigrationInstruction struct {
 	TempColumnIdentifier string
 }
 
-type ColumnMigrationStep func(dialect Dialect, table Table, instructions ...MigrationInstruction) ([]string, error)
+type ColumnMigrationStep func(dialect Dialect, table Table, instructions []MigrationInstruction) ([]string, error)
 
 var StdMigrationSteps = []ColumnMigrationStep{
-	func(dialect Dialect, table Table, instructions ...MigrationInstruction) ([]string, error) {
+	func(dialect Dialect, table Table, instructions []MigrationInstruction) ([]string, error) {
 		var queries []string
 		for _, ins := range instructions {
 			queries = append(
@@ -474,7 +474,7 @@ var StdMigrationSteps = []ColumnMigrationStep{
 
 		return queries, nil
 	},
-	func(dialect Dialect, table Table, instructions ...MigrationInstruction) ([]string, error) {
+	func(dialect Dialect, table Table, instructions []MigrationInstruction) ([]string, error) {
 		var query strings.Builder
 		query.WriteString(fmt.Sprintf("UPDATE %s SET ", table.Identifier))
 
@@ -490,7 +490,7 @@ var StdMigrationSteps = []ColumnMigrationStep{
 
 		return []string{query.String()}, nil
 	},
-	func(dialect Dialect, table Table, instructions ...MigrationInstruction) ([]string, error) {
+	func(dialect Dialect, table Table, instructions []MigrationInstruction) ([]string, error) {
 		var queries []string
 		for _, ins := range instructions {
 			queries = append(
@@ -504,7 +504,7 @@ var StdMigrationSteps = []ColumnMigrationStep{
 
 		return queries, nil
 	},
-	func(dialect Dialect, table Table, instructions ...MigrationInstruction) ([]string, error) {
+	func(dialect Dialect, table Table, instructions []MigrationInstruction) ([]string, error) {
 		var queries []string
 		for _, ins := range instructions {
 			queries = append(queries,
@@ -518,7 +518,7 @@ var StdMigrationSteps = []ColumnMigrationStep{
 
 		return queries, nil
 	},
-	func(dialect Dialect, table Table, instructions ...MigrationInstruction) ([]string, error) {
+	func(dialect Dialect, table Table, instructions []MigrationInstruction) ([]string, error) {
 		var queries []string
 
 		for _, ins := range instructions {
@@ -579,7 +579,7 @@ func StdColumnTypeMigrations(ctx context.Context, dialect Dialect, table Table,
 	var renderedSteps []string
 	for step, instructions := range stepInstructions {
 		for i, s := range steps[step:] {
-			newStep, err := s(dialect, table, instructions...)
+			newStep, err := s(dialect, table, instructions)
 			if err != nil {
 				return nil, fmt.Errorf("rendering step %d: %w", i, err)
 			}

materialize-sqlserver/client.go

@@ -89,7 +89,7 @@ func (c *client) InfoSchema(ctx context.Context, resourcePaths [][]string) (is *
 }
 
 var columnMigrationSteps = []sql.ColumnMigrationStep{
-	func(dialect sql.Dialect, table sql.Table, instructions ...sql.MigrationInstruction) ([]string, error) {
+	func(dialect sql.Dialect, table sql.Table, instructions []sql.MigrationInstruction) ([]string, error) {
 		var queries []string
 
 		for _, ins := range instructions {
@@ -105,7 +105,7 @@ var columnMigrationSteps = []sql.ColumnMigrationStep{
 
 		return queries, nil
 	},
-	func(dialect sql.Dialect, table sql.Table, instructions ...sql.MigrationInstruction) ([]string, error) {
+	func(dialect sql.Dialect, table sql.Table, instructions []sql.MigrationInstruction) ([]string, error) {
 		var query strings.Builder
 		query.WriteString(fmt.Sprintf("UPDATE %s SET ", table.Identifier))
 
@@ -119,7 +119,7 @@ var columnMigrationSteps = []sql.ColumnMigrationStep{
 		return []string{query.String()}, nil
 	},
 	sql.StdMigrationSteps[2],
-	func(dialect sql.Dialect, table sql.Table, instructions ...sql.MigrationInstruction) ([]string, error) {
+	func(dialect sql.Dialect, table sql.Table, instructions []sql.MigrationInstruction) ([]string, error) {
 		var queries []string
 
 		for _, ins := range instructions {
@@ -137,7 +137,7 @@ var columnMigrationSteps = []sql.ColumnMigrationStep{
 
 		return queries, nil
 	},
-	func(dialect sql.Dialect, table sql.Table, instructions ...sql.MigrationInstruction) ([]string, error) {
+	func(dialect sql.Dialect, table sql.Table, instructions []sql.MigrationInstruction) ([]string, error) {
 		var queries []string
 
 		for _, ins := range instructions {