Slight cleanup throughout #2575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
commented
Nov 20, 2024
| @@ -601,10 +601,6 @@ impl<'a> I2cFuture<'a> { | |||
|
|
|||
| w.arbitration_lost().set_bit(); | |||
| w.time_out().set_bit(); | |||
|
|
|||
| #[cfg(esp32)] | |||
There was a problem hiding this comment.
These are part of I2cFuture which we don't even implement for esp32
bugadani
commented
Nov 20, 2024
|
|
||
| | Feature | Supported CPUs | | ||
| | --------- | ---------------- | | ||
| | `esp32` | ESP32 (_LX6_) | |
There was a problem hiding this comment.
The features don't exist
bjoernQ
reviewed
Nov 21, 2024
bjoernQ
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
I guess having to update the version of critical-section in two places is fine given they appear very close together (and it would be fine even if not)
I wonder if we should have direct dependencies on xtensa-lx and riscv given they are re-exported from the rt crates? But upsteam riscv-rt doesn't so maybe just keep it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out of #2357 as these don't really belong there - most of the changes were done because of PAC updates, which landed separately.