Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim down xtensa-lx #2357

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Trim down xtensa-lx #2357

merged 2 commits into from
Nov 23, 2024

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Oct 16, 2024 •
edited
Loading

This PR removes some legacy code from the xtensa crates.

@MabezDev MabezDev mentioned this pull request Nov 1, 2024
Merged
@MabezDev
Copy link
Member

MabezDev commented Nov 1, 2024

esp-rs/esp-pacs#282 has been merged, I think we can get this ready now.

@bugadani
Copy link
Contributor Author

bugadani commented Nov 4, 2024

What should we do about esp_hal::sync? cortex-m and riscv define their own critical sections, so if we can somehow configure a core count for xtensa-lx we might do the same and move the impl there.

Or should we just provide a single-core feature and implemet a single-core critical section in xtensa-lx?

I'm not entirely sure how far we want to generalize this crate at this moment. I'm also not sure whether that question is in scope of this PR :)

@bugadani bugadani force-pushed the lx branch 3 times, most recently from de95efa to b9b8829 Compare November 4, 2024 11:44
@bugadani

This comment was marked as resolved.

Sign in to view
@bugadani

This comment was marked as resolved.

Sign in to view
@bugadani bugadani force-pushed the lx branch 3 times, most recently from fbda4bb to f9db793 Compare November 6, 2024 13:14
@bugadani bugadani added the skip-changelog No changelog modification needed label Nov 6, 2024
@bugadani bugadani mentioned this pull request Nov 20, 2024
Merged
@bugadani bugadani marked this pull request as ready for review November 22, 2024 09:38
@bugadani bugadani removed the skip-changelog No changelog modification needed label Nov 22, 2024
@bugadani
Copy link
Contributor Author

bugadani commented Nov 22, 2024 •
edited
Loading

This now needs a changelog entry :( I'll have to reapply the label, though, because of the esp-hal change.

@bugadani bugadani changed the title Trim down xtensa crates Trim down xtensa-lx Nov 22, 2024
@bugadani bugadani added the skip-changelog No changelog modification needed label Nov 22, 2024
bjoernQ
bjoernQ approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MabezDev MabezDev added this pull request to the merge queue Nov 23, 2024
Merged via the queue into esp-rs:main with commit 09511c7 Nov 23, 2024
28 of 29 checks passed
@bugadani bugadani deleted the lx branch November 23, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bugadani @MabezDev @bjoernQ