Resolve some pylint reported observations #3980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3980 +/- ##
==========================================
+ Coverage 58.04% 58.29% +0.24%
==========================================
Files 544 543 -1
Lines 41034 40776 -258
Branches 3772 3723 -49
==========================================
- Hits 23819 23771 -48
+ Misses 16232 15999 -233
- Partials 983 1006 +23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
You probably need a rebase on main ( there are conflicting files ) Then - you should probably squash your commits into one bigger one when you are done fixing the issue and write a descriptive message capturing the changes following the guidelines in the pre-review checklist stated in the PR message. |
andreas-el
force-pushed
the
refactor_pylint_observations
branch
from
15bcdd4 to
e60b404
Compare
andreas-el
changed the title
oysteoh
added
the
release-notes:improvement
andreas-el
force-pushed
the
refactor_pylint_observations
branch
from
e60b404 to
9f81390
Compare
oysteoh
approved these changes
Oct 5, 2022
Refactored reported inconsistent return statements to returning 'None' although this is implicitly done. Adds disable unexpected-keyword-arg to avoid false report for unitt_invalid_res_config test. Adds no-op pass statement to avoid pylint reported try-except-raise in exception handling. Replace Sphinx copyright variable with alias project_copyright. Renames variables using keywords func, sum, iter, hash, dir, filter, input. Adds default value for _func argument in plugin-response decorator. Adds guard if _func is not provided, plugin-response function shall return 'None'.
andreas-el
force-pushed
the
refactor_pylint_observations
branch
from
9f81390 to
58612a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #3965
Approach
Have split commits to separate refactoring done.
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.