Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve some of the Pylint reported issues #3965

Closed
andreas-el opened this issue Sep 30, 2022 · 0 comments · Fixed by #3980
Closed

Resolve some of the Pylint reported issues #3965

andreas-el opened this issue Sep 30, 2022 · 0 comments · Fixed by #3980
Assignees

Comments

@andreas-el
Copy link
Contributor

andreas-el commented Sep 30, 2022

Pylint ERT to resolve some of the detected refactors/warnings/errors etc.

Ref.
[Pylint ert] #3309

Report from start

(testenv) [andrli@be-lx128902 ert]$ pylint src tests docs test-data --reports=yes

...

Report
======
36169 statements analysed.

Statistics by type
------------------

+---------+-------+-----------+-----------+------------+---------+
|type     |number |old number |difference |%documented |%badname |
+=========+=======+===========+===========+============+=========+
|module   |727    |727        |=          |11.14       |0.00     |
+---------+-------+-----------+-----------+------------+---------+
|class    |507    |507        |=          |24.85       |3.55     |
+---------+-------+-----------+-----------+------------+---------+
|method   |2784   |2784       |=          |50.14       |28.30    |
+---------+-------+-----------+-----------+------------+---------+
|function |1539   |1539       |=          |25.67       |6.04     |
+---------+-------+-----------+-----------+------------+---------+



77499 lines have been analyzed

Raw metrics
-----------

+----------+-------+------+---------+-----------+
|type      |number |%     |previous |difference |
+==========+=======+======+=========+===========+
|code      |53322  |68.80 |53322    |=          |
+----------+-------+------+---------+-----------+
|docstring |7425   |9.58  |7425     |=          |
+----------+-------+------+---------+-----------+
|comment   |3485   |4.50  |3485     |=          |
+----------+-------+------+---------+-----------+
|empty     |13267  |17.12 |13267    |=          |
+----------+-------+------+---------+-----------+



Duplication
-----------

+-------------------------+------+---------+-----------+
|                         |now   |previous |difference |
+=========================+======+=========+===========+
|nb duplicated lines      |0     |0        |0          |
+-------------------------+------+---------+-----------+
|percent duplicated lines |0.000 |0.000    |=          |
+-------------------------+------+---------+-----------+



Messages by category
--------------------

+-----------+-------+---------+-----------+
|type       |number |previous |difference |
+===========+=======+=========+===========+
|convention |134    |134      |134        |
+-----------+-------+---------+-----------+
|refactor   |154    |154      |154        |
+-----------+-------+---------+-----------+
|warning    |778    |778      |778        |
+-----------+-------+---------+-----------+
|error      |38     |38       |38         |
+-----------+-------+---------+-----------+



Messages
--------

+-------------------------------+------------+
|message id                     |occurrences |
+===============================+============+
|unspecified-encoding           |406         |
+-------------------------------+------------+
|redefined-outer-name           |256         |
+-------------------------------+------------+
|too-many-arguments             |61          |
+-------------------------------+------------+
|wrong-import-position          |46          |
+-------------------------------+------------+
|consider-using-f-string        |35          |
+-------------------------------+------------+
|too-many-instance-attributes   |31          |
+-------------------------------+------------+
|unused-variable                |28          |
+-------------------------------+------------+
|line-too-long                  |28          |
+-------------------------------+------------+
|import-outside-toplevel        |25          |
+-------------------------------+------------+
|no-value-for-parameter         |19          |
+-------------------------------+------------+
|import-error                   |18          |
+-------------------------------+------------+
|too-many-statements            |17          |
+-------------------------------+------------+
|attribute-defined-outside-init |17          |
+-------------------------------+------------+
|redefined-builtin              |16          |
+-------------------------------+------------+
|unused-private-member          |15          |
+-------------------------------+------------+
|c-extension-no-member          |14          |
+-------------------------------+------------+
|broad-except                   |14          |
+-------------------------------+------------+
|too-many-return-statements     |11          |
+-------------------------------+------------+
|too-many-branches              |11          |
+-------------------------------+------------+
|keyword-arg-before-vararg      |11          |
+-------------------------------+------------+
|inconsistent-return-statements |9           |
+-------------------------------+------------+
|abstract-method                |8           |
+-------------------------------+------------+
|unnecessary-dict-index-lookup  |7           |
+-------------------------------+------------+
|too-many-public-methods        |7           |
+-------------------------------+------------+
|missing-timeout                |3           |
+-------------------------------+------------+
|assert-on-string-literal       |3           |
+-------------------------------+------------+
|unexpected-keyword-arg         |1           |
+-------------------------------+------------+
|try-except-raise               |1           |
+-------------------------------+------------+




------------------------------------------------------------------
Your code has been rated at 9.65/10 (previous run: 9.65/10, +0.00)
@andreas-el andreas-el added the bug label Sep 30, 2022
@andreas-el andreas-el self-assigned this Sep 30, 2022
@andreas-el andreas-el added this to SCOUT Sep 30, 2022
@andreas-el andreas-el moved this to In Progress in SCOUT Sep 30, 2022
@andreas-el andreas-el changed the title Resolve some of the Pylint resported issues Resolve some of the Pylint reported issues Oct 3, 2022
@andreas-el andreas-el linked a pull request Oct 4, 2022 that will close this issue
3 tasks
@andreas-el andreas-el moved this from In Progress to Ready for Review in SCOUT Oct 4, 2022
@oysteoh oysteoh moved this from Ready for Review to In Review in SCOUT Oct 4, 2022
Repository owner moved this from In Review to Done in SCOUT Oct 6, 2022
@eivindjahren eivindjahren moved this from Done to Done-Done in SCOUT Jan 2, 2023
@eivindjahren eivindjahren removed the bug label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants