perf: do not set last transition time for status in watcher layer #7268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudrakhp
force-pushed
the
ignore_transition_time_watcher
branch
4 times, most recently
from
0831236 to
ac80e07
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7268 +/- ##
==========================================
- Coverage 70.94% 70.94% -0.01%
==========================================
Files 229 229
Lines 41044 41127 +83
==========================================
+ Hits 29120 29177 +57
- Misses 10206 10234 +28
+ Partials 1718 1716 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Rudrakh Panigrahi <[email protected]>
rudrakhp
force-pushed
the
ignore_transition_time_watcher
branch
from
ac80e07 to
b1a00bc
Compare
arkodg
reviewed
Oct 24, 2025
|
|
||
| // setLastTransitionTimeInStatusConditions sets LastTransitionTime to the given time for all conditions in the status | ||
| // and returns a copy of the object with updated LastTransitionTime | ||
| func setLastTransitionTimeInStatusConditions(obj interface{}, timestamp time.Time) (client.Object, error) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
perf: do not set last transition time for status in watcher layer
What this PR does / why we need it:
Prevents watcher from getting updates due to changes in
LastTransitionTimein resource status conditions. Instead setLastTransitionTimefor all status conditions before apply.Which issue(s) this PR fixes:
Fixes #7158
Release Notes: No