perf: do not set last transition time for status in watcher layer

rudrakhp · rudrakhp · commit b1a00bc3e907 · 2025-10-19T16:01:18.000+05:30
Signed-off-by: Rudrakh Panigrahi &lt;rudrakh97@gmail.com&gt;
diff --git a/internal/gatewayapi/status/backend.go b/internal/gatewayapi/status/backend.go
@@ -14,8 +14,6 @@
 package status
 
 import (
-	"time"
-
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 
 	egv1a1 "github.com/envoyproxy/gateway/api/v1alpha1"
@@ -33,10 +31,10 @@ func computeBackendAcceptedCondition(be *egv1a1.Backend, accepted bool, msg stri
 	case true:
 		return newCondition(string(egv1a1.BackendReasonAccepted), metav1.ConditionTrue,
 			string(egv1a1.BackendConditionAccepted),
-			"The Backend was accepted", time.Now(), be.Generation)
+			"The Backend was accepted", be.Generation)
 	default:
 		return newCondition(string(egv1a1.BackendReasonInvalid), metav1.ConditionFalse,
 			string(egv1a1.BackendConditionAccepted),
-			msg, time.Now(), be.Generation)
+			msg, be.Generation)
 	}
 }
diff --git a/internal/gatewayapi/status/conditions.go b/internal/gatewayapi/status/conditions.go
@@ -14,7 +14,6 @@
 package status
 
 import (
-	"time"
 	"unicode"
 
 	"github.com/google/go-cmp/cmp"
@@ -42,7 +41,6 @@ func MergeConditions(conditions []metav1.Condition, updates ...metav1.Condition)
 					conditions[j].Reason = updates[i].Reason
 					conditions[j].Message = updates[i].Message
 					conditions[j].ObservedGeneration = updates[i].ObservedGeneration
-					conditions[j].LastTransitionTime = updates[i].LastTransitionTime
 					break
 				}
 			}
@@ -55,13 +53,12 @@ func MergeConditions(conditions []metav1.Condition, updates ...metav1.Condition)
 	return conditions
 }
 
-func newCondition(t string, status metav1.ConditionStatus, reason, msg string, lt time.Time, og int64) metav1.Condition {
+func newCondition(t string, status metav1.ConditionStatus, reason, msg string, og int64) metav1.Condition {
 	return metav1.Condition{
 		Type:               t,
 		Status:             status,
 		Reason:             reason,
 		Message:            truncateConditionMessage(msg),
-		LastTransitionTime: metav1.NewTime(lt),
 		ObservedGeneration: og,
 	}
 }
diff --git a/internal/gatewayapi/status/conditions_test.go b/internal/gatewayapi/status/conditions_test.go
@@ -17,17 +17,12 @@ import (
 	"errors"
 	"strings"
 	"testing"
-	"time"
 
 	"github.com/stretchr/testify/assert"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	utilclock "k8s.io/utils/clock"
-	fakeclock "k8s.io/utils/clock/testing"
 	gwapiv1 "sigs.k8s.io/gateway-api/apis/v1"
 )
 
-var clock utilclock.Clock = utilclock.RealClock{}
-
 func TestConditionChanged(t *testing.T) {
 	testCases := []struct {
 		name     string
@@ -95,17 +90,6 @@ func TestConditionChanged(t *testing.T) {
 }
 
 func TestMergeConditions(t *testing.T) {
-	// Inject a fake clock and don't forget to reset it
-	fakeClock := fakeclock.NewFakeClock(time.Time{})
-	clock = fakeClock
-	defer func() {
-		clock = utilclock.RealClock{}
-	}()
-
-	start := fakeClock.Now()
-	middle := start.Add(1 * time.Minute)
-	later := start.Add(2 * time.Minute)
-
 	gen := int64(1)
 
 	testCases := []struct {
@@ -117,69 +101,65 @@ func TestMergeConditions(t *testing.T) {
 		{
 			name: "status updated",
 			current: []metav1.Condition{
-				newCondition("available", "false", "Reason", "Message", start, gen),
+				newCondition("available", "false", "Reason", "Message", gen),
 			},
 			updates: []metav1.Condition{
-				newCondition("available", "true", "Reason", "Message", middle, gen),
+				newCondition("available", "true", "Reason", "Message", gen),
 			},
 			expected: []metav1.Condition{
-				newCondition("available", "true", "Reason", "Message", middle, gen),
+				newCondition("available", "true", "Reason", "Message", gen),
 			},
 		},
 		{
 			name: "reason updated",
 			current: []metav1.Condition{
-				newCondition("available", "false", "Reason", "Message", start, gen),
+				newCondition("available", "false", "Reason", "Message", gen),
 			},
 			updates: []metav1.Condition{
-				newCondition("available", "false", "New Reason", "Message", middle, gen),
+				newCondition("available", "false", "New Reason", "Message", gen),
 			},
 			expected: []metav1.Condition{
-				newCondition("available", "false", "New Reason", "Message", middle, gen),
+				newCondition("available", "false", "New Reason", "Message", gen),
 			},
 		},
 		{
 			name: "message updated",
 			current: []metav1.Condition{
-				newCondition("available", "false", "Reason", "Message", start, gen),
+				newCondition("available", "false", "Reason", "Message", gen),
 			},
 			updates: []metav1.Condition{
-				newCondition("available", "false", "Reason", "New Message", middle, gen),
+				newCondition("available", "false", "Reason", "New Message", gen),
 			},
 			expected: []metav1.Condition{
-				newCondition("available", "false", "Reason", "New Message", middle, gen),
+				newCondition("available", "false", "Reason", "New Message", gen),
 			},
 		},
 		{
 			name: "observed generation updated",
 			current: []metav1.Condition{
-				newCondition("available", "false", "Reason", "Message", start, gen),
+				newCondition("available", "false", "Reason", "Message", gen),
 			},
 			updates: []metav1.Condition{
-				newCondition("available", "false", "Reason", "Message", middle, gen+1),
+				newCondition("available", "false", "Reason", "Message", gen+1),
 			},
 			expected: []metav1.Condition{
-				newCondition("available", "false", "Reason", "Message", middle, gen+1),
+				newCondition("available", "false", "Reason", "Message", gen+1),
 			},
 		},
 		{
 			name: "status unchanged",
 			current: []metav1.Condition{
-				newCondition("available", "false", "Reason", "Message", start, gen),
+				newCondition("available", "false", "Reason", "Message", gen),
 			},
 			updates: []metav1.Condition{
-				newCondition("available", "false", "Reason", "Message", middle, gen),
+				newCondition("available", "false", "Reason", "Message", gen),
 			},
 			expected: []metav1.Condition{
-				newCondition("available", "false", "Reason", "Message", start, gen),
+				newCondition("available", "false", "Reason", "Message", gen),
 			},
 		},
 	}
 
-	// Simulate the passage of time between original condition creation
-	// and update processing
-	fakeClock.SetTime(later)
-
 	for _, tc := range testCases {
 		got := MergeConditions(tc.current, tc.updates...)
 		assert.ElementsMatch(t, tc.expected, got, tc.name)
@@ -188,7 +168,7 @@ func TestMergeConditions(t *testing.T) {
 
 func TestMergeConditionsTruncatesMessages(t *testing.T) {
 	longMsg := strings.Repeat("x", conditionMessageMaxLength+5)
-	cond := newCondition("available", metav1.ConditionTrue, "Reason", longMsg, time.Now(), 1)
+	cond := newCondition("available", metav1.ConditionTrue, "Reason", longMsg, 1)
 	conditions := MergeConditions(nil, cond)
 
 	if assert.Len(t, conditions, 1) {
diff --git a/internal/gatewayapi/status/envoypatchpolicy.go b/internal/gatewayapi/status/envoypatchpolicy.go
@@ -7,7 +7,6 @@ package status
 
 import (
 	"strings"
-	"time"
 
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	gwapiv1 "sigs.k8s.io/gateway-api/apis/v1"
@@ -30,22 +29,22 @@ func SetProgrammedForEnvoyPatchPolicy(s *gwapiv1.PolicyStatus) {
 	}
 
 	message := "Patches have been successfully applied."
-	cond := newCondition(string(egv1a1.PolicyConditionProgrammed), metav1.ConditionTrue, string(egv1a1.PolicyReasonProgrammed), message, time.Now(), 0)
+	cond := newCondition(string(egv1a1.PolicyConditionProgrammed), metav1.ConditionTrue, string(egv1a1.PolicyReasonProgrammed), message, 0)
 	for i := range s.Ancestors {
 		s.Ancestors[i].Conditions = MergeConditions(s.Ancestors[i].Conditions, cond)
 	}
 }
 
 func SetTranslationErrorForEnvoyPatchPolicy(s *gwapiv1.PolicyStatus, errMsg string) {
-	cond := newCondition(string(egv1a1.PolicyConditionProgrammed), metav1.ConditionFalse, string(egv1a1.PolicyReasonInvalid), errMsg, time.Now(), 0)
+	cond := newCondition(string(egv1a1.PolicyConditionProgrammed), metav1.ConditionFalse, string(egv1a1.PolicyReasonInvalid), errMsg, 0)
 	for i := range s.Ancestors {
 		s.Ancestors[i].Conditions = MergeConditions(s.Ancestors[i].Conditions, cond)
 	}
 }
 
 func SetResourceNotFoundErrorForEnvoyPatchPolicy(s *gwapiv1.PolicyStatus, notFoundResources []string) {
 	message := "Unable to find xds resources: " + strings.Join(notFoundResources, ",")
-	cond := newCondition(string(egv1a1.PolicyConditionProgrammed), metav1.ConditionFalse, string(egv1a1.PolicyReasonResourceNotFound), message, time.Now(), 0)
+	cond := newCondition(string(egv1a1.PolicyConditionProgrammed), metav1.ConditionFalse, string(egv1a1.PolicyReasonResourceNotFound), message, 0)
 	for i := range s.Ancestors {
 		s.Ancestors[i].Conditions = MergeConditions(s.Ancestors[i].Conditions, cond)
 	}
diff --git a/internal/gatewayapi/status/gateway.go b/internal/gatewayapi/status/gateway.go
@@ -8,7 +8,6 @@ package status
 import (
 	"fmt"
 	"slices"
-	"time"
 
 	appsv1 "k8s.io/api/apps/v1"
 	corev1 "k8s.io/api/core/v1"
@@ -19,14 +18,14 @@ import (
 )
 
 func UpdateGatewayStatusNotAccepted(gw *gwapiv1.Gateway, reason gwapiv1.GatewayConditionReason, msg string) *gwapiv1.Gateway {
-	cond := newCondition(string(gwapiv1.GatewayConditionAccepted), metav1.ConditionFalse, string(reason), msg, time.Now(), gw.Generation)
+	cond := newCondition(string(gwapiv1.GatewayConditionAccepted), metav1.ConditionFalse, string(reason), msg, gw.Generation)
 	gw.Status.Conditions = MergeConditions(gw.Status.Conditions, cond)
 	return gw
 }
 
 func UpdateGatewayStatusAccepted(gw *gwapiv1.Gateway) *gwapiv1.Gateway {
 	cond := newCondition(string(gwapiv1.GatewayConditionAccepted), metav1.ConditionTrue,
-		string(gwapiv1.GatewayReasonAccepted), "The Gateway has been scheduled by Envoy Gateway", time.Now(), gw.Generation)
+		string(gwapiv1.GatewayReasonAccepted), "The Gateway has been scheduled by Envoy Gateway", gw.Generation)
 	gw.Status.Conditions = MergeConditions(gw.Status.Conditions, cond)
 	return gw
 }
@@ -144,7 +143,6 @@ func SetGatewayListenerStatusCondition(gateway *gwapiv1.Gateway, listenerStatusI
 		Reason:             string(reason),
 		Message:            message,
 		ObservedGeneration: gateway.Generation,
-		LastTransitionTime: metav1.NewTime(time.Now()),
 	}
 	gateway.Status.Listeners[listenerStatusIdx].Conditions = MergeConditions(gateway.Status.Listeners[listenerStatusIdx].Conditions, cond)
 }
@@ -162,14 +160,14 @@ func updateGatewayProgrammedCondition(gw *gwapiv1.Gateway, envoyObj client.Objec
 	if len(gw.Status.Addresses) == 0 {
 		gw.Status.Conditions = MergeConditions(gw.Status.Conditions,
 			newCondition(string(gwapiv1.GatewayConditionProgrammed), metav1.ConditionFalse, string(gwapiv1.GatewayReasonAddressNotAssigned),
-				messageAddressNotAssigned, time.Now(), gw.Generation))
+				messageAddressNotAssigned, gw.Generation))
 		return
 	}
 
 	if len(gw.Status.Addresses) > 16 {
 		gw.Status.Conditions = MergeConditions(gw.Status.Conditions,
 			newCondition(string(gwapiv1.GatewayConditionProgrammed), metav1.ConditionFalse, string(gwapiv1.GatewayReasonInvalid),
-				fmt.Sprintf(messageFmtTooManyAddresses, len(gw.Status.Addresses)), time.Now(), gw.Generation))
+				fmt.Sprintf(messageFmtTooManyAddresses, len(gw.Status.Addresses)), gw.Generation))
 
 		// Truncate the addresses to 16
 		// so that the status can be updated successfully.
@@ -183,14 +181,14 @@ func updateGatewayProgrammedCondition(gw *gwapiv1.Gateway, envoyObj client.Objec
 		if obj != nil && obj.Status.AvailableReplicas > 0 {
 			gw.Status.Conditions = MergeConditions(gw.Status.Conditions,
 				newCondition(string(gwapiv1.GatewayConditionProgrammed), metav1.ConditionTrue, string(gwapiv1.GatewayConditionProgrammed),
-					fmt.Sprintf(messageFmtProgrammed, obj.Status.AvailableReplicas, obj.Status.Replicas), time.Now(), gw.Generation))
+					fmt.Sprintf(messageFmtProgrammed, obj.Status.AvailableReplicas, obj.Status.Replicas), gw.Generation))
 			return
 		}
 	case *appsv1.DaemonSet:
 		if obj != nil && obj.Status.NumberAvailable > 0 {
 			gw.Status.Conditions = MergeConditions(gw.Status.Conditions,
 				newCondition(string(gwapiv1.GatewayConditionProgrammed), metav1.ConditionTrue, string(gwapiv1.GatewayConditionProgrammed),
-					fmt.Sprintf(messageFmtProgrammed, obj.Status.NumberAvailable, obj.Status.CurrentNumberScheduled), time.Now(), gw.Generation))
+					fmt.Sprintf(messageFmtProgrammed, obj.Status.NumberAvailable, obj.Status.CurrentNumberScheduled), gw.Generation))
 			return
 		}
 	}
@@ -199,7 +197,7 @@ func updateGatewayProgrammedCondition(gw *gwapiv1.Gateway, envoyObj client.Objec
 	// Envoy DaemonSet, don't mark the Gateway as ready yet.
 	gw.Status.Conditions = MergeConditions(gw.Status.Conditions,
 		newCondition(string(gwapiv1.GatewayConditionProgrammed), metav1.ConditionFalse, string(gwapiv1.GatewayReasonNoResources),
-			messageNoResources, time.Now(), gw.Generation))
+			messageNoResources, gw.Generation))
 }
 
 // GetGatewayListenerStatusConditions returns the status conditions for a specific listener in the gateway status.
diff --git a/internal/gatewayapi/status/gatewayclass.go b/internal/gatewayapi/status/gatewayclass.go
@@ -14,8 +14,6 @@
 package status
 
 import (
-	"time"
-
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/util/sets"
 	gwapiv1 "sigs.k8s.io/gateway-api/apis/v1"
@@ -57,7 +55,6 @@ func computeGatewayClassAcceptedCondition(gatewayClass *gwapiv1.GatewayClass,
 			Reason:             reason,
 			Message:            msg,
 			ObservedGeneration: gatewayClass.Generation,
-			LastTransitionTime: metav1.NewTime(time.Now()),
 		}
 	default:
 		return metav1.Condition{
@@ -66,7 +63,6 @@ func computeGatewayClassAcceptedCondition(gatewayClass *gwapiv1.GatewayClass,
 			Reason:             reason,
 			Message:            msg,
 			ObservedGeneration: gatewayClass.Generation,
-			LastTransitionTime: metav1.NewTime(time.Now()),
 		}
 	}
 }
diff --git a/internal/gatewayapi/status/policy.go b/internal/gatewayapi/status/policy.go
@@ -7,7 +7,6 @@ package status
 
 import (
 	"sort"
-	"time"
 
 	"k8s.io/apimachinery/pkg/api/meta"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -104,14 +103,14 @@ func SetConditionForPolicyAncestor(policyStatus *gwapiv1.PolicyStatus, ancestorR
 			}
 
 			// Only create condition and merge if needed
-			cond := newCondition(string(conditionType), status, string(reason), sanitizedMessage, time.Now(), generation)
+			cond := newCondition(string(conditionType), status, string(reason), sanitizedMessage, generation)
 			policyStatus.Ancestors[i].Conditions = MergeConditions(policyStatus.Ancestors[i].Conditions, cond)
 			return
 		}
 	}
 
 	// Add condition for new PolicyAncestorStatus
-	cond := newCondition(string(conditionType), status, string(reason), sanitizedMessage, time.Now(), generation)
+	cond := newCondition(string(conditionType), status, string(reason), sanitizedMessage, generation)
 	policyStatus.Ancestors = append(policyStatus.Ancestors, gwapiv1.PolicyAncestorStatus{
 		AncestorRef:    *ancestorRef,
 		ControllerName: gwapiv1a2.GatewayController(controllerName),
diff --git a/internal/gatewayapi/status/route.go b/internal/gatewayapi/status/route.go
@@ -6,8 +6,6 @@
 package status
 
 import (
-	"time"
-
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	gwapiv1 "sigs.k8s.io/gateway-api/apis/v1"
 )
@@ -21,7 +19,6 @@ func SetRouteStatusCondition(route *gwapiv1.RouteStatus, routeParentStatusIdx in
 		Reason:             string(reason),
 		Message:            message,
 		ObservedGeneration: routeGeneration,
-		LastTransitionTime: metav1.NewTime(time.Now()),
 	}
 
 	route.Parents[routeParentStatusIdx].Conditions = MergeConditions(route.Parents[routeParentStatusIdx].Conditions, cond)
diff --git a/internal/provider/kubernetes/status_updater.go b/internal/provider/kubernetes/status_updater.go
diff --git a/internal/provider/kubernetes/status_updater_test.go b/internal/provider/kubernetes/status_updater_test.go

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,6 @@`
`14`	`14`	`package status`
`15`	`15`
`16`	`16`	`import (`
`17`		`- "time"`
`18`	`17`	`"unicode"`
`19`	`18`
`20`	`19`	`"github.com/google/go-cmp/cmp"`
`@@ -42,7 +41,6 @@ func MergeConditions(conditions []metav1.Condition, updates ...metav1.Condition)`
`42`	`41`	`conditions[j].Reason = updates[i].Reason`
`43`	`42`	`conditions[j].Message = updates[i].Message`
`44`	`43`	`conditions[j].ObservedGeneration = updates[i].ObservedGeneration`
`45`		`- conditions[j].LastTransitionTime = updates[i].LastTransitionTime`
`46`	`44`	`break`
`47`	`45`	`}`
`48`	`46`	`}`
`@@ -55,13 +53,12 @@ func MergeConditions(conditions []metav1.Condition, updates ...metav1.Condition)`
`55`	`53`	`return conditions`
`56`	`54`	`}`
`57`	`55`
`58`		`-func newCondition(t string, status metav1.ConditionStatus, reason, msg string, lt time.Time, og int64) metav1.Condition {`
	`56`	`+func newCondition(t string, status metav1.ConditionStatus, reason, msg string, og int64) metav1.Condition {`
`59`	`57`	`return metav1.Condition{`
`60`	`58`	`Type: t,`
`61`	`59`	`Status: status,`
`62`	`60`	`Reason: reason,`
`63`	`61`	`Message: truncateConditionMessage(msg),`
`64`		`- LastTransitionTime: metav1.NewTime(lt),`
`65`	`62`	`ObservedGeneration: og,`
`66`	`63`	`}`
`67`	`64`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,6 @@ package status`
`7`	`7`
`8`	`8`	`import (`
`9`	`9`	`"strings"`
`10`		`- "time"`
`11`	`10`
`12`	`11`	`metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"`
`13`	`12`	`gwapiv1 "sigs.k8s.io/gateway-api/apis/v1"`
`@@ -30,22 +29,22 @@ func SetProgrammedForEnvoyPatchPolicy(s *gwapiv1.PolicyStatus) {`
`30`	`29`	`}`
`31`	`30`
`32`	`31`	`message := "Patches have been successfully applied."`
`33`		`- cond := newCondition(string(egv1a1.PolicyConditionProgrammed), metav1.ConditionTrue, string(egv1a1.PolicyReasonProgrammed), message, time.Now(), 0)`
	`32`	`+ cond := newCondition(string(egv1a1.PolicyConditionProgrammed), metav1.ConditionTrue, string(egv1a1.PolicyReasonProgrammed), message, 0)`
`34`	`33`	`for i := range s.Ancestors {`
`35`	`34`	`s.Ancestors[i].Conditions = MergeConditions(s.Ancestors[i].Conditions, cond)`
`36`	`35`	`}`
`37`	`36`	`}`
`38`	`37`
`39`	`38`	`func SetTranslationErrorForEnvoyPatchPolicy(s *gwapiv1.PolicyStatus, errMsg string) {`
`40`		`- cond := newCondition(string(egv1a1.PolicyConditionProgrammed), metav1.ConditionFalse, string(egv1a1.PolicyReasonInvalid), errMsg, time.Now(), 0)`
	`39`	`+ cond := newCondition(string(egv1a1.PolicyConditionProgrammed), metav1.ConditionFalse, string(egv1a1.PolicyReasonInvalid), errMsg, 0)`
`41`	`40`	`for i := range s.Ancestors {`
`42`	`41`	`s.Ancestors[i].Conditions = MergeConditions(s.Ancestors[i].Conditions, cond)`
`43`	`42`	`}`
`44`	`43`	`}`
`45`	`44`
`46`	`45`	`func SetResourceNotFoundErrorForEnvoyPatchPolicy(s *gwapiv1.PolicyStatus, notFoundResources []string) {`
`47`	`46`	`message := "Unable to find xds resources: " + strings.Join(notFoundResources, ",")`
`48`		`- cond := newCondition(string(egv1a1.PolicyConditionProgrammed), metav1.ConditionFalse, string(egv1a1.PolicyReasonResourceNotFound), message, time.Now(), 0)`
	`47`	`+ cond := newCondition(string(egv1a1.PolicyConditionProgrammed), metav1.ConditionFalse, string(egv1a1.PolicyReasonResourceNotFound), message, 0)`
`49`	`48`	`for i := range s.Ancestors {`
`50`	`49`	`s.Ancestors[i].Conditions = MergeConditions(s.Ancestors[i].Conditions, cond)`
`51`	`50`	`}`
Original file line number	Diff line number	Diff line change
`@@ -14,8 +14,6 @@`
`14`	`14`	`package status`
`15`	`15`
`16`	`16`	`import (`
`17`		`- "time"`
`18`		`-`
`19`	`17`	`metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"`
`20`	`18`	`"k8s.io/apimachinery/pkg/util/sets"`
`21`	`19`	`gwapiv1 "sigs.k8s.io/gateway-api/apis/v1"`
`@@ -57,7 +55,6 @@ func computeGatewayClassAcceptedCondition(gatewayClass *gwapiv1.GatewayClass,`
`57`	`55`	`Reason: reason,`
`58`	`56`	`Message: msg,`
`59`	`57`	`ObservedGeneration: gatewayClass.Generation,`
`60`		`- LastTransitionTime: metav1.NewTime(time.Now()),`
`61`	`58`	`}`
`62`	`59`	`default:`
`63`	`60`	`return metav1.Condition{`
`@@ -66,7 +63,6 @@ func computeGatewayClassAcceptedCondition(gatewayClass *gwapiv1.GatewayClass,`
`66`	`63`	`Reason: reason,`
`67`	`64`	`Message: msg,`
`68`	`65`	`ObservedGeneration: gatewayClass.Generation,`
`69`		`- LastTransitionTime: metav1.NewTime(time.Now()),`
`70`	`66`	`}`
`71`	`67`	`}`
`72`	`68`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,8 +6,6 @@`
`6`	`6`	`package status`
`7`	`7`
`8`	`8`	`import (`
`9`		`- "time"`
`10`		`-`
`11`	`9`	`metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"`
`12`	`10`	`gwapiv1 "sigs.k8s.io/gateway-api/apis/v1"`
`13`	`11`	`)`
`@@ -21,7 +19,6 @@ func SetRouteStatusCondition(route *gwapiv1.RouteStatus, routeParentStatusIdx in`
`21`	`19`	`Reason: string(reason),`
`22`	`20`	`Message: message,`
`23`	`21`	`ObservedGeneration: routeGeneration,`
`24`		`- LastTransitionTime: metav1.NewTime(time.Now()),`
`25`	`22`	`}`
`26`	`23`
`27`	`24`	`route.Parents[routeParentStatusIdx].Conditions = MergeConditions(route.Parents[routeParentStatusIdx].Conditions, cond)`