Skip to content

[audioworklet] Fix test_audio_worklet shutdown hang. #25326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2025
Merged

[audioworklet] Fix test_audio_worklet shutdown hang. #25326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39bd548
[audioworklet] Fix test_audio_worklet shutdown hang.
brendandahl Sep 19, 2025
9ef3125
Automatic rebaseline of codesize expectations. NFC
brendandahl Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/codesize/test_minimal_runtime_code_size_audio_worklet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"a.html.gz": 357,
"a.js": 4077,
"a.js.gz": 2137,
"a.wasm": 1298,
"a.wasm.gz": 868,
"total": 5894,
"total_gz": 3362
"a.wasm": 1308,
"a.wasm.gz": 876,
"total": 5904,
"total_gz": 3370
}
5 changes: 4 additions & 1 deletion test/webaudio/audioworklet.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
begin to fire.
*/

EMSCRIPTEN_WEBAUDIO_T context;

// TEST_AND_EXIT is defined when running in the Emscripten test harness. You can
// strip these out in your own project (otherwise playback will end quickly).
#ifdef TEST_AND_EXIT
Expand Down Expand Up @@ -70,6 +72,7 @@ bool main_thread_tls_access(double time, void *userData) {
testTlsVariable = (int)time;
// Exit to the test harness after enough calls to ProcessAudio()
if (lastTlsVariableValueInAudioThread >= 100) {
emscripten_destroy_audio_context(context);
emscripten_force_exit(0);
}
return true;
Expand Down Expand Up @@ -128,7 +131,7 @@ int main() {
assert(!emscripten_current_thread_is_audio_worklet());

// Create an audio context
EMSCRIPTEN_WEBAUDIO_T context = emscripten_create_audio_context(0 /* use default constructor options */);
context = emscripten_create_audio_context(0 /* use default constructor options */);

// and kick off Audio Worklet scope initialization, which shares the Wasm
// Module and Memory to the AudioWorklet scope and initializes its stack.
Expand Down