Skip to content

[audioworklet] Fix test_audio_worklet shutdown hang. #25326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 22, 2025
Merged

[audioworklet] Fix test_audio_worklet shutdown hang. #25326

merged 2 commits into from
Sep 22, 2025

Conversation

brendandahl
Copy link
Collaborator

No description provided.

@brendandahl
Automatic rebaseline of codesize expectations. NFC
9ef3125 
This is an automatic change generated by tools/maint/rebaseline_tests.py.

The following (1) test expectation files were updated by
running the tests with `--rebaseline`:

```
codesize/test_minimal_runtime_code_size_audio_worklet.json: 5894 => 5904 [+10 bytes / +0.17%]

Average change: +0.17% (+0.17% - +0.17%)
```
@brendandahl
Copy link
Collaborator Author

Bummer, looks like there was a hang with on the last run in test_audio_worklet_strict.

@brendandahl
Copy link
Collaborator Author

Maybe the hang is from and interaction with the previous test test_audio_worklet_worker that I haven't fixed. I'll land both the fixes and see if we get this anymore.

@brendandahl brendandahl merged commit 608b5fe into emscripten-core:main Sep 22, 2025
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brendandahl @sbc100