Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pkg conf #1

Merged
merged 4 commits into from
May 19, 2021
Merged

update pkg conf #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dee5ea5
codejedi365-update-pkg-conf > update pkg-lock for updated package.json
codejedi365 May 14, 2021
bfc3fb8
codejedi365-update-pkg-conf > config pkg testing
codejedi365 May 14, 2021
b7a1e49
codejedi365-update-pkg-conf > Add notes to pkg
codejedi365 May 14, 2021
db067e4
codejedi365-update-pkg-conf > better test output
codejedi365 May 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Options:
Install this package.

```
npm install --save-dev gitlab-npm-audit-parser
npm install --save-dev @elpete/gitlab-npm-audit-parser
```

Add the following job to _.gitlab-ci.yml_
Expand All @@ -30,11 +30,16 @@ dependency scanning:
reports:
dependency_scanning: gl-dependency-scanning.json
```
NOTE: If you use a `npm run-script` to call `npm audit` You must add the option `--silent` to `npm run` or have `.npmrc` set the NPM loglevel to silent otherwise the shell output will conflict with the stdin piping to this parser and cause an error.

## Test

```sh
$ npm test
```

### V1 Report
`cat test/v1_report.json | ./parse.js -o report.json`

### V2 Report
`cat test/v1_report.json | ./parse.js -o report.json`
`cat test/v2_report.json | ./parse.js -o report.json`
19 changes: 10 additions & 9 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 13 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
"test": "test"
},
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
"test": "npm run --silent test:v1; npm run --silent test:v2;",
"test:v1": "printf 'v1: '; cat test/v1_report.json | ./parse.js -o GL-report.1.json >/dev/null && diff -q GL-report.1.json test/snapshot/GL-report.1.json && echo success!; RC=$?; rm GL-report.1.json; exit $RC",
"test:v2": "printf 'v2: '; cat test/v2_report.json | ./parse.js -o GL-report.2.json >/dev/null && diff -q GL-report.2.json test/snapshot/GL-report.2.json && echo success!; RC=$?; rm GL-report.2.json; exit $RC"
},
"repository": {
"type": "git",
Expand All @@ -19,11 +21,16 @@
],
"author": "Maxime Gibeau",
"contributors": [
{
"name": "Eric Peterson",
"email": "[email protected]",
"url": "https://github.com/elpete"
}
{
"name": "Eric Peterson",
"email": "[email protected]",
"url": "https://github.com/elpete"
},
{
"name": "codejedi365",
"email": "[email protected]",
"url": "https://github.com/codejedi365"
}
],
"license": "MIT",
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion parse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ stdin.on('end', function () {
var inputJSON = chunks.join(''),
outputJSON = convert(inputJSON);

fs.writeFile(filename, outputJSON, function(err) {
fs.writeFile(filename, outputJSON+'\n', function(err) {
if (err) {
return console.log(err);
}
Expand Down
Loading