Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pkg conf #1

Merged
merged 4 commits into from
May 19, 2021
Merged

Conversation

codejedi365
Copy link

@elpete, thanks again for making this fork (fixing my mgibeau#8) and publishing it on npm since the original seems to be dormant.

I figured I can return the favor a bit and made some updates to your package. Primarily small simple edits in this PR.

Purpose

Update this package so that it works properly and does not get mixed up with the original gitlab-npm-audit-parser when using npx. Update the readme to adequately define this package as well as automate the tests for the project to ensure the output is the desired output all the time.

How to verify

# 1. checkout this branch
# 2. Install the dependencies from scratch
$ npm ci
# 3. Run automated tests
$ npm test

### Rationale
Automates the testcases using the npm test infrastructure
(`npm test`).  Adds the actual expected outcomes as defined files which
are verified to be the same
Also ensures the output file has a EOF character at end.
### Rationale
Tests were not providing a bad exit code & the latest npm v7.13.0, also
no longer throws an abnoxous error on a failed run-scripts.

This should be a bit easier to determine when testing.
@elpete
Copy link
Owner

elpete commented May 19, 2021

Looks great. Thanks!

@elpete elpete merged commit 3adccd1 into elpete:main May 19, 2021
@elpete
Copy link
Owner

elpete commented May 19, 2021

Published as 1.1.1

@codejedi365 codejedi365 deleted the codejedi365-update-pkg-conf branch May 19, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants